Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] 1.43.1 release #71868

Merged
merged 7 commits into from
May 5, 2020
Merged

[stable] 1.43.1 release #71868

merged 7 commits into from
May 5, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented May 4, 2020 •
edited
Loading

@Mark-Simulacrum
Copy link
Member Author

cc @cuviper -- I wasn't able to force push to your branch so ended up creating a new PR, but should include everything in #71774.

@Mark-Simulacrum
Copy link
Member Author

r? @pietroalbini for final sign off (I can run release if you want, up to you though)

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 4, 2020
Closed
@pietroalbini
Copy link
Member

Does the stdarch diff only contain the cherry-picked changes needed to fix the regression, or is it just a bump to master?

@cuviper
Copy link
Member

cuviper commented May 4, 2020

The stdarch bump matches master, but that was reviewed in #71774.

@pietroalbini
Copy link
Member

Ok then!

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented May 4, 2020

📌 Commit 6e40414 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 4, 2020
@bors
Copy link
Contributor

bors commented May 4, 2020

⌛ Testing commit 6e40414 with merge 671b11b41652cc1f43c564732e908ea8ee839524...

@bors
Copy link
Contributor

bors commented May 4, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2020
@Mark-Simulacrum
Copy link
Member Author

CloudABI certificates seem to not be working?

2020-05-04T13:57:45.4403532Z Err:10 https://nuxi.nl/distfiles/cloudabi-ports/debian cloudabi Release
2020-05-04T13:57:45.4406666Z   Certificate verification failed: The certificate is NOT trusted. The certificate chain uses expired certificate.  Could not handshake: Error in the certificate verification. [IP: 144.76.176.173 443]
2020-05-04T13:57:46.4958482Z Reading package lists...
2020-05-04T13:57:46.5290332Z �[91mE: The repository 'https://nuxi.nl/distfiles/cloudabi-ports/debian cloudabi Release' does not have a Release file.

@pietroalbini
Copy link
Member

Tried copying the cached Docker image from GHA.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@bors
Copy link
Contributor

bors commented May 4, 2020

⌛ Testing commit 6e40414 with merge 16e487fbc8f242fb52e0f614969e72ff574a40f3...

@bors
Copy link
Contributor

bors commented May 4, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2020
@pietroalbini
Copy link
Member

Mirrored the whole APT archives of CloudABI in our S3 bucket. This is safe as the contents of the archive are all signed, so any tampering will be detected by APT.

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented May 4, 2020

📌 Commit f862628a5fcae42e6532d0ca3fd5e01f5bb96b29 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@bors
Copy link
Contributor

bors commented May 4, 2020

⌛ Testing commit f862628a5fcae42e6532d0ca3fd5e01f5bb96b29 with merge 8a5815b2e39d2186b4ca6d799e8c753cef3f2b78...

@bors
Copy link
Contributor

bors commented May 4, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2020
@Mark-Simulacrum
Copy link
Member Author

2020-05-04T20:50:15.5343586Z tidy error: /checkout/src/ci/docker/dist-various-2/build-cloudabi-toolchain.sh:36: line longer than 100 chars

Fixing...

@pietroalbini @Mark-Simulacrum
fetch cloudabi packages from our own mirror
54bc3e5 
The upstream archive went down due to an expired certificate, so I
mirrored the whole thing on our mirrors S3 bucket. This is safe, as the
certificate just seemed to be expired and the contents of the APT
archive are signed anyway.
@Mark-Simulacrum
Copy link
Member Author

@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented May 4, 2020

📌 Commit 54bc3e5 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@bors
Copy link
Contributor

bors commented May 4, 2020

⌛ Testing commit 54bc3e5 with merge ffda75b7473db657401c8ec4f5bf761fb9cb9058...

@bors
Copy link
Contributor

bors commented May 4, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2020
@cuviper
Copy link
Member

cuviper commented May 4, 2020

Some arches in stdarch aren't using llvm_asm! after all -- I allowed the lint on that.

@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented May 4, 2020

📌 Commit 1eb1c8d has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2020
@bors
Copy link
Contributor

bors commented May 4, 2020

⌛ Testing commit 1eb1c8d with merge 8d69840...

@bors
Copy link
Contributor

bors commented May 5, 2020

☀️ Test successful - checks-azure
Approved by: pietroalbini
Pushing 8d69840 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2020
@bors bors merged commit 8d69840 into rust-lang:stable May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @pietroalbini @cuviper @bors @Amanieu