Suggest removing semicolon in last expression only if it's type is known #71894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
mibac138
force-pushed
the
semicolon-not-always-helpful
branch
from
767a413 to
d7664ba
Compare
estebank
reviewed
May 5, 2020
mibac138
force-pushed
the
semicolon-not-always-helpful
branch
from
d7664ba to
ca72352
Compare
|
@bors r+ rollup |
|
📌 Commit ca72352 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#69984 (Add Option to Force Unwind Tables) - rust-lang#71830 (Remove clippy from some leftover lists of "possibly failing" tools) - rust-lang#71894 (Suggest removing semicolon in last expression only if it's type is known) - rust-lang#71897 (Improve docs for embed-bitcode and linker-plugin-lto) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67971
Is there a syntax for explicitly checking if a note doesn't exist in test output? Something like
//~ !NOTE ...I believe r? @estebank deals with diagnostics.