Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap for windows #71974

Closed
wants to merge 1 commit into from

Conversation

mibac138
Copy link
Contributor

@mibac138 mibac138 commented May 7, 2020

Since #71819 x.py doesn't work for me. This PR fixes that. To be honest I'm kind of confused how this didn't get caught by CI. Error:

Traceback (most recent call last):
  File "x.py", line 11, in <module>
    bootstrap.main()
  File "C:\Users\mibac\IdeaProjects\rust\src\bootstrap\bootstrap.py", line 960, in main
    bootstrap(help_triggered)
  File "C:\Users\mibac\IdeaProjects\rust\src\bootstrap\bootstrap.py", line 925, in bootstrap
    build.build = args.build or build.build_triple()
  File "C:\Users\mibac\IdeaProjects\rust\src\bootstrap\bootstrap.py", line 731, in build_triple
    return default_build_triple()
  File "C:\Users\mibac\IdeaProjects\rust\src\bootstrap\bootstrap.py", line 184, in default_build_triple
    ostype = require(["uname", "-s"], exit=required).decode(default_encoding)
AttributeError: 'NoneType' object has no attribute 'decode'

r? @Mark-Simulacrum who reviewed the previous PR

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2020
@mibac138 mibac138 force-pushed the bootstrap-go-brrr branch from 3e23297 to 6013e55 Compare May 7, 2020 07:42
@retep998
Copy link
Member

retep998 commented May 7, 2020

CI has MinGW installed and in PATH, even for pc-windows-msvc builds. It would be nice to have a builder that has no msys/mingw stuff in PATH whatsoever.

Also isn't this technically a dupe of #71964 ?

@mibac138
Copy link
Contributor Author

mibac138 commented May 7, 2020

Oh, I didn't notice that pr. Thanks

@mibac138 mibac138 closed this May 7, 2020
@mibac138 mibac138 deleted the bootstrap-go-brrr branch May 7, 2020 08:46
@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants