Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ty::List into a new submodule #72060

Merged
merged 1 commit into from
May 16, 2020
Merged

move ty::List into a new submodule #72060

merged 1 commit into from
May 16, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 9, 2020

rustc_middle/ty is currently right below the 3000 lines tidy file length limit.

Moves rustc_middle::ty::List to the private module rustc_middle::ty::list and adds
a pub use self::list::List at its previous location.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2020

📌 Commit bb6a6e0 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2020
@cjgillot
Copy link
Contributor

Can this be moved out of librustc_middle? For example libarena?

@lcnr
Copy link
Contributor Author

lcnr commented May 11, 2020

Afaict no, as there are implementations for List<InternalType> in rustc_middle.

@lcnr lcnr mentioned this pull request May 11, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72045 (Incomplete features can also be unsound)
 - rust-lang#72047 (Literal error reporting cleanup)
 - rust-lang#72060 (move `ty::List` into a new submodule)
 - rust-lang#72094 (cmdline: Make target features individually overridable)
 - rust-lang#72254 (Remove redundant backtick in error message.)

Failed merges:

r? @ghost
@bors bors merged commit ae66c62 into rust-lang:master May 16, 2020
@lcnr lcnr deleted the move-list branch May 16, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants