Rename traits::Vtable to ImplSource. #72114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
I agree that the name |
|
@eddyb and I mentioned |
Elinvynia
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #70705) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #71996) made this pull request unmergeable. Please resolve the merge conflicts. |
anyska
changed the title
|
☔ The latest upstream changes (presumably #72948) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
approved these changes
Jun 8, 2020
|
@bors r+ |
|
📌 Commit 00c19ad has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Merged
This was referenced Jun 9, 2020
ptrojahn
added a commit
to ptrojahn/rust
that referenced
this pull request
Jul 9, 2021
As rust-lang#72114 and rust-lang#73055 were merged so closely together I think this accidentally happened while rebasing
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 10, 2021
…-schievink Revert the revert of renaming traits::VTable to ImplSource As rust-lang#72114 and rust-lang#73055 were merged so closely together I think this accidentally happened while rebasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally suggested by @eddyb.
r? @nikomatsakis