syntax::diagnostics: Color the ^~~~ in green for better visibility #7230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be nicer to colour it corresponding to whatever the diagnostic message is? Green for note, yellow for warning, red for error. |
|
At the moment this patch emulates the coloring that clang does. I personally don't care either way, as long as it's colored somehow :) |
|
@Blei I'd like to see the caret the color of the diagnostic, and the squiggly be colored white. |
|
(I mean as long as we're going fancy we might as well go fancy) |
Closed
|
closing this out due to the bors madness. please re-open, it's not landed. |
thestinger
added a commit
that referenced
this pull request
Jun 22, 2013
syntax::diagnostics: Color the ^~~~ in green for better visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7164.