Rollup of 5 pull requests #72326
Closed
Rollup of 5 pull requests #72326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Closure is non-capturing
…Equate obligation. This delays the need to evaluate consts eagerly and therefore gets around const eval query cycles.
…ariables. This means a inference variable can be unified with an unevaluated const.
Support coercion between (FnDef | Closure) and (FnDef | Closure) Fixes rust-lang#46742, fixes rust-lang#48109 Inject `Closure` into the `FnDef x FnDef` coercion special case, which makes coercion of `(FnDef | Closure) x (FnDef | Closure)` possible, where closures should be **non-capturing**.
Lazy normalization of constants (Reprise) Continuation of rust-lang#67890 by @Skinny121. Initial implementation of rust-lang#60471 for constants. Perform normalization/evaluation of constants lazily, which is known as lazy normalization. Lazy normalization is only enabled when using `#![feature(lazy_normalization_consts)]`, by default constants are still evaluated eagerly as there are currently. Lazy normalization of constants is achieved with a new ConstEquate predicate which type inferences uses to delay checking whether constants are equal to each other until later, avoiding cycle errors. Note this doesn't allow the use of generics within repeat count expressions as that is still evaluated during conversion to mir. There are also quite a few other known problems with lazy normalization which will be fixed in future PRs. r? @nikomatsakis fixes rust-lang#71922, fixes rust-lang#71986
correctly handle uninferred consts fixes the ICE mentioned in rust-lang#70507 (comment) I originally tried to generalize `need_type_info_err` to also work with consts which was not as much fun as I hoped 😅 It might be easier to have some duplication here and handle consts separately. r? @varkor
Add newer rust versions to linker-plugin-lto.md Hi, This doc got a bit out of date, it's hosted here: https://doc.rust-lang.org/rustc/linker-plugin-lto.html you can check the versions I've added via: ```bash $ rustup install 1.38.0 $ rustc +1.38.0 -vV rustc 1.38.0 (625451e 2019-09-23) binary: rustc commit-hash: 625451e commit-date: 2019-09-23 host: x86_64-unknown-linux-gnu release: 1.38.0 LLVM version: 9.0 $ rustup install 1.43.1 $ rustc +1.43.1 -vV rustc 1.43.1 (8d69840 2020-05-04) binary: rustc commit-hash: 8d69840 commit-date: 2020-05-04 host: x86_64-unknown-linux-gnu release: 1.43.1 LLVM version: 9.0 ```
…omatsakis Add help text for remote-test-client Add help text describing the usage of remote-test-client
|
@bors r+ rollup=never p=5 |
|
📌 Commit 1178941 has been approved by |
bors
added
the
S-waiting-on-bors
|
This is already failing in PR CI tests: @bors r- |
bors
added
S-waiting-on-author
|
re-rolling |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost