Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in -Zsave-analysis #72338

Merged
merged 1 commit into from
May 19, 2020
Merged

Fix ICE in -Zsave-analysis #72338

merged 1 commit into from
May 19, 2020

Conversation

doctorn
Copy link
Contributor

@doctorn doctorn commented May 18, 2020

Puts a short-circuit in to avoid an ICE in -Zsave-analysis.

r? @ecstatic-morse

Resolves #72267

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2020
@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented May 18, 2020

@ljedrz Any idea how to fix this more robustly?

In the meantime, I'll approve once nits are fixed addressed.

src/librustc_save_analysis/lib.rs Outdated Show resolved Hide resolved
@ecstatic-morse
Copy link
Contributor

@bors r+ rollup

Thanks @doctorn!

@bors
Copy link
Contributor

bors commented May 18, 2020

📌 Commit ef3f2c0 has been approved by ecstatic-morse

@bors
Copy link
Contributor

bors commented May 18, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71886 (Stabilize saturating_abs and saturating_neg)
 - rust-lang#72066 (correctly handle uninferred consts)
 - rust-lang#72068 (Ignore arguments when looking for `IndexMut` for subsequent `mut` obligation)
 - rust-lang#72338 (Fix ICE in -Zsave-analysis)
 - rust-lang#72344 (Assert doc wording)

Failed merges:

r? @ghost
@bors bors merged commit 8178808 into rust-lang:master May 19, 2020
@doctorn doctorn deleted the trait-object-ice branch May 19, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
5 participants