-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new gdb/lldb pretty-printers #72357
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 49a16c895f7c63843ef7a8f18e3589d170cbb94e has been approved by |
maybe not r+ with the ci change think that was only to find why test faild |
@bors r- |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
49a16c8
to
692442e
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
63e2f4f
to
ece6812
Compare
This touches a lot of tests, so I was wondering if it fixes #47163 |
ece6812
to
bbf7df4
Compare
@tromey How can I check it? Just try to remove |
bbf7df4
to
b86bfe1
Compare
Looks like I've fixed all the failing pretty-printers tests @bors try |
@ortem: 🔑 Insufficient privileges: not in try users |
I was more asking if your patch uncommented the "ignore"s from any tests you touched; a lot of the tests already pass and are seemingly disabled for no reason. Not super important, but maybe that bug could also be closed by this. |
@bors try |
⌛ Trying commit b86bfe183ef80454018c3350fe39466933813de5 with merge 7ccc5e3a9ca4a94c72b84322b79c136c0ae793c0... |
☀️ Try build successful - checks-azure |
9e6b814
to
23ff93b
Compare
⌛ Testing commit 23ff93baad1c4e7464b8ab55d89d0df8c0db7037 with merge a4fe9d9f307e81a37e934a26a395043c7d62f032... |
💔 Test failed - checks-azure |
23ff93b
to
6c47429
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
6c47429
to
dc13e99
Compare
Replace old GDB and LLDB pretty-printers with new ones which were originally written for IntelliJ Rust. New LLDB pretty-printers support synthetic children. New GDB/LLDB pretty-printers support all Rust types supported by old pretty-printers, and also support: Rc, Arc, Cell, Ref, RefCell, RefMut, HashMap, HashSet.
dc13e99
to
27be73e
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
27be73e
to
47c26e6
Compare
Some tests fail on gdb 7.11.1. I couldn't find out what's the reason, so I've disabled them for gdb < 8.1
|
@bors r+ |
📌 Commit 47c26e6 has been approved by |
☀️ Test successful - checks-azure |
…acrum Fix loading pretty-printers in rust-lldb script Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357 This fixes rust-lang#76006
…acrum Fix loading pretty-printers in rust-lldb script Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357 This fixes rust-lang#76006
…acrum Fix loading pretty-printers in rust-lldb script Pretty-printers loading in `rust-lldb` script was broken in rust-lang#72357 This fixes rust-lang#76006
Compiler's pretty-printers were updated in rust-lang/rust#72357
Reopened #60826
This PR replaces current gdb and lldb pretty-printers with new ones that were originally written for IntelliJ Rust.
The current state of lldb pretty-printers is poor, because they don't use synthetic children. When I started to reimplement lldb pretty-printers with synthetic children support, I've found current version strange and hard to support. I think
debugger_pretty_printers_common.py
is overkill, so I got rid of it.The new pretty-printers have to support all types supported by current pretty-printers, and also support
Rc
,Arc
,Cell
,Ref
,RefCell
,RefMut
,HashMap
,HashSet
.Fixes #56252