Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #72539

Merged
merged 18 commits into from
May 24, 2020
Merged

Rollup of 5 pull requests #72539

merged 18 commits into from
May 24, 2020

Commits on May 21, 2020

  1. Configuration menu
    Copy the full SHA
    5728c53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c5dba7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52359f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13c86f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    25f575b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    21f65ae View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8ff6ffd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4c4cb46 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f31e076 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Configuration menu
    Copy the full SHA
    7a121ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2220eb4 View commit details
    Browse the repository at this point in the history
  3. Use dyn trait syntax in more comments and docs

    Probably missed it out during earlier `dyn` refactoring.
    ratijas authored May 24, 2020
    Configuration menu
    Copy the full SHA
    d1f4796 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df2f9a4 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72402 - marmeladema:resolver-outputs-def-id…

    …, r=ecstatic-morse
    
    Remove all uses of `NodeId` in `ResolverOutputs`
    
    cc rust-lang#50928
    
    r? @ecstatic-morse
    RalfJung authored May 24, 2020
    Configuration menu
    Copy the full SHA
    95c4583 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72527 - RalfJung:miri-clippy-test-args, r=M…

    …ark-Simulacrum
    
    bootstrap: propagate test-args to miri and clippy test suites
    
    For Miri I verified this works. For clippy, unfortunately it doesn't seem to work as a stage 0 tool:
    ```
    ./x.py --stage 0 test src/tools/clippy --test-args init
    ```
    gives
    ```
       Compiling clippy-mini-macro-test v0.2.0 (/home/r/src/rust/rustc.3/src/tools/clippy/mini-macro)
    error[E0658]: procedural macros cannot be expanded to expressions
      --> src/tools/clippy/mini-macro/src/lib.rs:11:5
       |
    11 | /     quote!(
    12 | |         #[allow(unused)]
    13 | |         fn needless_take_by_value(s: String) {
    14 | |             println!("{}", s.len());
    ...  |
    24 | |         }
    25 | |     )
       | |_____^
       |
       = note: see issue rust-lang#54727 <rust-lang#54727> for more information
       = help: add `#![feature(proc_macro_hygiene)]` to the crate attributes to enable
    
       Compiling proc-macro2 v1.0.3
       Compiling syn v1.0.11
    error: aborting due to previous error
    
    For more information about this error, try `rustc --explain E0658`.
    error: could not compile `clippy-mini-macro-test`.
    ```
    But propagating `--test-args` to the test suite seems to make sense regardless.
    Cc @rust-lang/clippy
    RalfJung authored May 24, 2020
    Configuration menu
    Copy the full SHA
    a75068a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#72530 - GuillaumeGomez:cleanup-e0602, r=Dyl…

    …an-DPC
    
    Clean up E0602 explanation
    
    r? @Dylan-DPC
    RalfJung authored May 24, 2020
    Configuration menu
    Copy the full SHA
    cdeef96 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#72532 - ratijas:dyn-trait-object-doc, r=jon…

    …as-schievink
    
    Use `dyn` trait syntax in more comments and docs
    
    Probably missed it out during earlier dyn refactoring.
    
    033cbfe#diff-a0ba6bbf82d9ee83a4c9525873f85b04
    RalfJung authored May 24, 2020
    Configuration menu
    Copy the full SHA
    67b4e2b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#72535 - saschanaz:patch-1, r=jonas-schievink

    Use sort_unstable_by in its own docs
    
    Currently it uses `sort_by` instead of itself.
    RalfJung authored May 24, 2020
    Configuration menu
    Copy the full SHA
    134a165 View commit details
    Browse the repository at this point in the history