Remove legacy InnoSetup GUI installer #72569

ChrisDenton · 2020-05-25T12:29:15Z

On Windows the InnoSetup .exe installer was superseded by the MSI installer long ago. It's no longer needed.

The .exe installer hasn't been linked from the other installation methods page in many years. As far as I can tell the intent was always to remove this installer once the MSI proved itself. Though admittedly both installers feel very "legacy" at this point.

Removing this would mean we only maintain one Windows GUI installer and would speed up the distribution phase.

As a result of removing InnoSetup, this closes #24397

rust-highfive · 2020-05-25T12:29:19Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

On Windows the InnoSetup installer was superseded by the MSI installer. It's no longer needed.

joshtriplett · 2020-05-27T06:27:30Z

cc @retep998 (for Windows-specific review)

retep998 · 2020-05-27T08:56:49Z

At this point the only place I can think of that would still use this is some ancient CI configurations. I know winapi used to use these before I switched to rustup for testing arm cross builds.

Hopefully we can soon get movement on installing rustup to a sane location on windows (please don't block it on xdg/Mac questions)

nikomatsakis · 2020-05-28T16:54:28Z

@retep998 was that a "r+"?

retep998 · 2020-05-28T23:28:22Z

@retep998 was that a "r+"?

I plead the fifth.

nikomatsakis · 2020-06-01T22:12:34Z

Heh. OK. Well I'm inclined to go forward with this PR (closes a bug! gets rid of older things!) but I'd like to hear more from @rust-lang/release or @rust-lang/compiler folks who might have thoughts on whether it makes sense.

XAMPPRocky · 2020-06-02T08:19:47Z

I didn’t even know we had this and has been mentioned this installer is not even linked on forge, so I don’t think there’s much motivation to keep it. I do think it would best to have some kind of announcement of the removal alongside this change though. The announcement itself could be as small as adding a compatibility note to the next release.

nikomatsakis · 2020-06-02T13:36:19Z

Good point. Tagging with relnotes, as this seems worth noting under "compatibility notes", per @XAMPPRocky's suggestion.

pietroalbini · 2020-06-03T09:38:26Z

I'd love to get more feedback from the community on this, either with a well publicized internals thread or even better with a quick RFC (like we did with the 32-bit Apple targets).

nikomatsakis · 2020-06-08T15:29:23Z

@pietroalbini those both sound like reasonable suggestions.

nikomatsakis · 2020-06-10T13:06:28Z

@ChrisDenton can you create an internals thread requesting feedback? You can also create a post for the Inside Rust blog if you prefer.

ChrisDenton · 2020-06-10T14:09:46Z

@nikomatsakis, sure! I'm just trying to word it right. Is it sufficient to provide a short summary with a link to this PR or should I try to expand upon the reasoning (and potential drawbacks)?

nikomatsakis · 2020-06-10T22:35:50Z

@ChrisDenton I think a short summary with a link to this PR would suffice, yes

Elinvynia · 2020-06-25T21:06:28Z

Ping from triage:
@ChrisDenton Hello, sorry to bother, has the thread been created?

ChrisDenton · 2020-06-25T22:07:33Z

@Elinvynia Yep! It was also mentioned on an Inside Rust blog post.

It hasn't had any feedback in the last two weeks. That's not entirely unexpected. The installer was removed from the website before the release of Rust 1.0 so I'd guess very few people are even aware of it.

nikomatsakis · 2020-06-26T20:04:21Z

We do now have a Windows notification group up and going, so I'm going to ping them just to see if anybody wants to weigh in, but I think I'm ready to move forward and land this PR. Thanks @ChrisDenton for your patience. =)

@rustbot ping windows

rustbot · 2020-06-26T20:04:23Z

Hey Windows Group! This bug has been identified as a good "Windows candidate".
In case it's useful, here are some instructions for tackling these sorts of
bugs. Maybe take a look?
Thanks! <3

cc @arlosi @danielframpton @gdr-at-ms @kennykerr @luqmana @lzybkr @retep998 @rylev @sivadeilra @spastorino

nikomatsakis · 2020-07-01T21:25:01Z

@bors r+

going to assume that everybody is good with this.

bors · 2020-07-01T21:25:03Z

📌 Commit 912963b has been approved by nikomatsakis

…omatsakis Remove legacy InnoSetup GUI installer On Windows the InnoSetup `.exe` installer was superseded by the MSI installer long ago. It's no longer needed. The `.exe` installer hasn't been linked from the [other installation methods](https://forge.rust-lang.org/infra/other-installation-methods.html#standalone) page in many years. As far as I can tell the intent was always to remove this installer once the MSI proved itself. Though admittedly both installers feel very "legacy" at this point. Removing this would mean we only maintain one Windows GUI installer and would speed up the distribution phase. As a result of removing InnoSetup, this closes rust-lang#24397

@ghost

…arth Rollup of 16 pull requests Successful merges: - rust-lang#72569 (Remove legacy InnoSetup GUI installer) - rust-lang#73306 (Don't implement Fn* traits for #[target_feature] functions) - rust-lang#73345 (expand: Stop using nonterminals for passing tokens to attribute and derive macros) - rust-lang#73449 (Provide more information on duplicate lang item error.) - rust-lang#73569 (Handle `macro_rules!` tokens consistently across crates) - rust-lang#73803 (Recover extra trailing angle brackets in struct definition) - rust-lang#73839 (Split and expand nonstandard-style lints unicode unit test.) - rust-lang#73841 (Remove defunct `-Z print-region-graph`) - rust-lang#73848 (Fix markdown rendering in librustc_lexer docs) - rust-lang#73865 (Fix Zulip topic format) - rust-lang#73892 (Clean up E0712 explanation) - rust-lang#73898 (remove duplicate test for rust-lang#61935) - rust-lang#73906 (Add missing backtick in `ty_error_with_message`) - rust-lang#73909 (`#[deny(unsafe_op_in_unsafe_fn)]` in libstd/fs.rs) - rust-lang#73910 (Rewrite a few manual index loops with while-let) - rust-lang#73929 (Fix comment typo) Failed merges: r? @ghost

according to various people on tech-pkg@, there are no problems with the Firefox build Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.][72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you cast a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.][72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

Pkgsrc changes: * Portability patches for Illumos have been intregrated upstream, so are no longer needed in pkgsrc. * Adjust one other patch, and update vendor/libc cargo checksum. Upstream changes: Version 1.46.0 (2020-08-27) ========================== Language -------- - [`if`, `match`, and `loop` expressions can now be used in const functions.] [72437] - [Additionally you are now also able to coerce and cast to slices (`&[T]`) in const functions.][73862] - [The `#[track_caller]` attribute can now be added to functions to use the function's caller's location information for panic messages.][72445] - [Recursively indexing into tuples no longer needs parentheses.][71322] E.g. `x.0.0` over `(x.0).0`. - [`mem::transmute` can now be used in static and constants.][72920] **Note** You currently can't use `mem::transmute` in constant functions. Compiler -------- - [You can now use the `cdylib` target on Apple iOS and tvOS platforms.][73516] - [Enabled static "Position Independent Executables" by default for `x86_64-unknown-linux-musl`.][70740] Libraries --------- - [`mem::forget` is now a `const fn`.][73887] - [`String` now implements `From<char>`.][73466] - [The `leading_ones`, and `trailing_ones` methods have been stabilised for all integer types.][73032] - [`vec::IntoIter<T>` now implements `AsRef<[T]>`.][72583] - [All non-zero integer types (`NonZeroU8`) now implement `TryFrom` for their zero-able equivalent (e.g. `TryFrom<u8>`).][72717] - [`&[T]` and `&mut [T]` now implement `PartialEq<Vec<T>>`.][71660] - [`(String, u16)` now implements `ToSocketAddrs`.][73007] - [`vec::Drain<'_, T>` now implements `AsRef<[T]>`.][72584] Stabilized APIs --------------- - [`Option::zip`] - [`vec::Drain::as_slice`] Cargo ----- Added a number of new environment variables that are now available when compiling your crate. - [`CARGO_BIN_NAME` and `CARGO_CRATE_NAME`][cargo/8270] Providing the name of the specific binary being compiled and the name of the crate. - [`CARGO_PKG_LICENSE`][cargo/8325] The license from the manifest of the package. - [`CARGO_PKG_LICENSE_FILE`][cargo/8387] The path to the license file. Compatibility Notes ------------------- - [The target configuration option `abi_blacklist` has been renamed to `unsupported_abis`.][74150] The old name will still continue to work. - [Rustc will now warn if you have a C-like enum that implements `Drop`.][72331] This was previously accepted but will become a hard error in a future release. - [Rustc will fail to compile if you have a struct with `#[repr(i128)]` or `#[repr(u128)]`.][74109] This representation is currently only allowed on `enum`s. - [Tokens passed to `macro_rules!` are now always captured.][73293] This helps ensure that spans have the correct information, and may cause breakage if you were relying on receiving spans with dummy information. - [The InnoSetup installer for Windows is no longer available.][72569] This was a legacy installer that was replaced by a MSI installer a few years ago but was still being built. - [`{f32, f64}::asinh` now returns the correct values for negative numbers.] [72486] - [Rustc will no longer accept overlapping trait implementations that only differ in how the lifetime was bound.][72493] - [Rustc now correctly relates the lifetime of an existential associated type.][71896] This fixes some edge cases where `rustc` would erroneously allow you to pass a shorter lifetime than expected. - [Rustc now dynamically links to `libz` (also called `zlib`) on Linux.][74420] The library will need to be installed for `rustc` to work, even though we expect it to be already available on most systems. - [Tests annotated with `#[should_panic]` are broken on ARMv7 while running under QEMU.][74820] - [Pretty printing of some tokens in procedural macros changed.][75453] The exact output returned by rustc's pretty printing is an unstable implementation detail: we recommend any macro relying on it to switch to a more robust parsing system. [75453]: rust-lang/rust#75453 [74820]: rust-lang/rust#74820 [74420]: rust-lang/rust#74420 [74109]: rust-lang/rust#74109 [74150]: rust-lang/rust#74150 [73862]: rust-lang/rust#73862 [73887]: rust-lang/rust#73887 [73466]: rust-lang/rust#73466 [73516]: rust-lang/rust#73516 [73293]: rust-lang/rust#73293 [73007]: rust-lang/rust#73007 [73032]: rust-lang/rust#73032 [72920]: rust-lang/rust#72920 [72569]: rust-lang/rust#72569 [72583]: rust-lang/rust#72583 [72584]: rust-lang/rust#72584 [72717]: rust-lang/rust#72717 [72437]: rust-lang/rust#72437 [72445]: rust-lang/rust#72445 [72486]: rust-lang/rust#72486 [72493]: rust-lang/rust#72493 [72331]: rust-lang/rust#72331 [71896]: rust-lang/rust#71896 [71660]: rust-lang/rust#71660 [71322]: rust-lang/rust#71322 [70740]: rust-lang/rust#70740 [cargo/8270]: rust-lang/cargo#8270 [cargo/8325]: rust-lang/cargo#8325 [cargo/8387]: rust-lang/cargo#8387 [`Option::zip`]: https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.zip [`vec::Drain::as_slice`]: https://doc.rust-lang.org/stable/std/vec/struct.Drain.html#method.as_slice

rust-highfive assigned nikomatsakis May 25, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2020

Remove legacy InnoSetup GUI installer

912963b

On Windows the InnoSetup installer was superseded by the MSI installer. It's no longer needed.

nikomatsakis added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 2, 2020

jonas-schievink added this to the 1.45 milestone Jun 2, 2020

kennytm added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jun 11, 2020

Elinvynia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2020

Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 26, 2020

rustbot added the O-windows Operating system: Windows label Jun 26, 2020

Dylan-DPC-zz modified the milestones: 1.45, 1.46 Jun 29, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2020

Manishearth mentioned this pull request Jul 2, 2020

Rollup of 16 pull requests #73944

Closed

Manishearth mentioned this pull request Jul 2, 2020

Rollup of 17 pull requests #73946

Closed

Manishearth mentioned this pull request Jul 2, 2020

Rollup of 17 pull requests #73947

Closed

Manishearth mentioned this pull request Jul 2, 2020

Rollup of 16 pull requests #73950

Merged

bors merged commit fb976e6 into rust-lang:master Jul 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy InnoSetup GUI installer #72569

Remove legacy InnoSetup GUI installer #72569

ChrisDenton commented May 25, 2020

rust-highfive commented May 25, 2020

joshtriplett commented May 27, 2020

retep998 commented May 27, 2020

nikomatsakis commented May 28, 2020

retep998 commented May 28, 2020

nikomatsakis commented Jun 1, 2020

XAMPPRocky commented Jun 2, 2020 •

edited

Loading

nikomatsakis commented Jun 2, 2020

pietroalbini commented Jun 3, 2020

nikomatsakis commented Jun 8, 2020

nikomatsakis commented Jun 10, 2020

ChrisDenton commented Jun 10, 2020 •

edited

Loading

nikomatsakis commented Jun 10, 2020

Elinvynia commented Jun 25, 2020

ChrisDenton commented Jun 25, 2020 •

edited

Loading

nikomatsakis commented Jun 26, 2020

rustbot commented Jun 26, 2020

nikomatsakis commented Jul 1, 2020

bors commented Jul 1, 2020

Remove legacy InnoSetup GUI installer #72569

Remove legacy InnoSetup GUI installer #72569

Conversation

ChrisDenton commented May 25, 2020

rust-highfive commented May 25, 2020

joshtriplett commented May 27, 2020

retep998 commented May 27, 2020

nikomatsakis commented May 28, 2020

retep998 commented May 28, 2020

nikomatsakis commented Jun 1, 2020

XAMPPRocky commented Jun 2, 2020 • edited Loading

nikomatsakis commented Jun 2, 2020

pietroalbini commented Jun 3, 2020

nikomatsakis commented Jun 8, 2020

nikomatsakis commented Jun 10, 2020

ChrisDenton commented Jun 10, 2020 • edited Loading

nikomatsakis commented Jun 10, 2020

Elinvynia commented Jun 25, 2020

ChrisDenton commented Jun 25, 2020 • edited Loading

nikomatsakis commented Jun 26, 2020

rustbot commented Jun 26, 2020

nikomatsakis commented Jul 1, 2020

bors commented Jul 1, 2020

XAMPPRocky commented Jun 2, 2020 •

edited

Loading

ChrisDenton commented Jun 10, 2020 •

edited

Loading

ChrisDenton commented Jun 25, 2020 •

edited

Loading