Improve IR codegen #7259
Merged
Improve IR codegen #7259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Currently, by-copy function arguments are always stored into a scratch datum, which serves two purposes. First, it is required to be able to have a temporary cleanup, in case that the call fails before the callee actually takes ownership of the value. Second, if the argument is to be passed by reference, the copy is required, so that the function doesn't get a reference to the original value. But in case that the datum does not need a drop glue call and it is passed by value, there's no need to perform the extra copy.
By using "void" instead of "{}" as the LLVM type for nil, we can avoid
the alloca/store/load sequence for the return value, resulting in less
and simpler IR code.
This reduces compile times by about 10%.
bors
added a commit
that referenced
this pull request
Jun 21, 2013
The changes in these commits improve the IR codegen by removing unnecessary copies for certain function call arguments and stopping to allocate return values for functions returning nil. They reduce compile times by about 10% in total.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 3, 2021
…_trait, r=llogiq Fix invalid syntax in `from_iter_instead_of_collect` suggestion First attempt at contributing, hopefully this is a good start and can be improved. :) fixes rust-lang#7259 changelog: [`from_iter_instead_of_collect`] fix invalid suggestion involving "as Trait"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in these commits improve the IR codegen by removing unnecessary copies for certain function call arguments and stopping to allocate return values for functions returning nil. They reduce compile times by about 10% in total.