Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working example for E0617 explanation #72605

Merged
merged 1 commit into from
May 29, 2020
Merged

Add working example for E0617 explanation #72605

merged 1 commit into from
May 29, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 26, 2020

📌 Commit 695623a has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 26, 2020
@Dylan-DPC
Rollup merge of rust-lang#72605 - GuillaumeGomez:cleanup-e0617, r=Dyl…
aabcb25 
…an-DPC

Add working example for E0617 explanation

r? @Dylan-DPC
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 26, 2020
Closed
@JohnTitor
Copy link
Member

Failed in #72612 (comment):

failures:

---- /Users/runner/runners/2.169.0/work/1/s/build/x86_64-apple-darwin/test/error-index.md - Rust_Compiler_Error_Index::E0617 (line 12015) stdout ----
Test executable failed (terminated by signal).


failures:
    /Users/runner/runners/2.169.0/work/1/s/build/x86_64-apple-darwin/test/error-index.md - Rust_Compiler_Error_Index::E0617 (line 12015)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2020
@GuillaumeGomez
Copy link
Member Author

Forgot to add no_run. Updated!

@JohnTitor
Copy link
Member

@bors r=Dylan-DPC

@bors
Copy link
Contributor

bors commented May 28, 2020

📌 Commit 5548e69 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 29, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2020
@bors
Auto merge of rust-lang#72716 - Dylan-DPC:rollup-wdj97ab, r=Dylan-DPC
255c033 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#72239 (Implement PartialOrd and Ord for SocketAddr*)
 - rust-lang#72466 (Stabilize str_strip feature)
 - rust-lang#72605 (Add working example for E0617 explanation)
 - rust-lang#72636 (Cleanup `Resolver::<clone|into>_outputs` methods)
 - rust-lang#72645 (Add myself to .mailmap)
 - rust-lang#72667 (expand unaligned_references test)
 - rust-lang#72670 (Fix incorrect comment in generator test)
 - rust-lang#72674 (Clippy should always build)
 - rust-lang#72682 (Add test for rust-lang#66930)
 - rust-lang#72695 (update data layout for illumos x86)
 - rust-lang#72697 (Remove rustc-ux-guidelines)
 - rust-lang#72702 (rustc_lint: Remove `unused_crate_dependencies` from the `unused` group)

Failed merges:

r? @ghost
@bors bors merged commit 235f382 into rust-lang:master May 29, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0617 branch May 29, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @Dylan-DPC-zz @bors @JohnTitor @rust-highfive