WIP: snapshot test for #72550 #72665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
test this commit by running: (cd src/test/run-make-fulldeps/issue-72550/ && RUSTC=rustc LD_LIB_PATH_ENVVAR=DYLD_LIBRARY_PATH make)
Curiously, this also has no line numbers
alsuren
commented
May 30, 2020
| 8: std::rt::lang_start::{{closure}} | ||
| 9: std::rt::lang_start_internal | ||
| 10: std::rt::lang_start | ||
| 11: main |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
alsuren
commented
May 30, 2020
| 12: test::main | ||
| at ./test.rs:2 | ||
| 13: std::rt::lang_start::{{closure}} | ||
| at /Users/alsuren/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src/libstd/rt.rs:67 |
There was a problem hiding this comment.
This is clearly not being run in CI.
nikomatsakis
added
S-blocked
|
Marking as S-blocked until such time as you would like review comments here, @alsuren =) |
|
Ah. I was hoping that marking it as a Draft PR would be enough to sail under your radar. In this PR, I was trying to think of a good integration test to endure that I always have line numbers in backtraces on OSX. On reflection, I don't think that this is the right approach. It doesn't get caught by the PR bulid process, so it will just end up with a bunch of spurious flakes down the line that are a pain to fix. In parallel with this, the original issue has been fixed, and I have started using vscode remote on azure, so all of my compilation and debugging happens on a beefy linux box. Closing now, because it's not the right approach, and doesn't seem worth polishing. Hopefully it wasn't too distracting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Nothing to see here. Just making a PR to kick off the CI]
I was thinking about how to write a regression test for #72550, once it's fixed. Part of me thinks that a snapshot test is the answer. I have a feeling that this will annoy anyone that needs to edit anything in
core::fmt::writestd::io::Write``std::panicking::*orstd::rt::*, because they will perturb the snapshot.I'm probably going to sleep on this.
I haven't even looked at how to fix the underlying issue. Just trying to make a regression test, to help out however I can.