Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add str to common types #72689

Merged
merged 1 commit into from
Jun 20, 2020
Merged

add str to common types #72689

merged 1 commit into from
Jun 20, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 28, 2020

I already expected this to be the case and it may slightly improve perf.

Afaict if we ever want to change str into a lang item this would have to get reverted.
As that would be fairly simple I don't believe this to cause any problems in the future.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2020
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented May 28, 2020

⌛ Trying commit b3aa5e3 with merge 0a7e41a7f21b2d47d7249db60e3aeef322329a8e...

@bors
Copy link
Contributor

bors commented May 28, 2020

☀️ Try build successful - checks-azure
Build commit: 0a7e41a7f21b2d47d7249db60e3aeef322329a8e (0a7e41a7f21b2d47d7249db60e3aeef322329a8e)

@rust-timer
Copy link
Collaborator

Queued 0a7e41a7f21b2d47d7249db60e3aeef322329a8e with parent 4512721, future comparison URL.

@estebank estebank added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 0a7e41a7f21b2d47d7249db60e3aeef322329a8e, comparison URL.

@lcnr lcnr removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 28, 2020
@lcnr
Copy link
Contributor Author

lcnr commented May 28, 2020

This change is absolutely irrelevant it seems 🤷 I am still in favor of merging this though,
as it feels cleaner to me.

@joshtriplett
Copy link
Member

This seems entirely reasonable to me.

@Elinvynia Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2020
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 19, 2020

📌 Commit b3aa5e3 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2020
…arth

Rollup of 16 pull requests

Successful merges:

 - rust-lang#71420 (Specialization is unsound)
 - rust-lang#71899 (Refactor `try_find` a little)
 - rust-lang#72689 (add str to common types)
 - rust-lang#72791 (update coerce docs and unify relevant tests)
 - rust-lang#72934 (forbid mutable references in all constant contexts except for const-fns)
 - rust-lang#73027 (Make `need_type_info_err` more conservative)
 - rust-lang#73347 (Diagnose use of incompatible sanitizers)
 - rust-lang#73359 (shim.rs: avoid creating `Call` terminators calling `Self`)
 - rust-lang#73399 (Clean up E0668 explanation)
 - rust-lang#73436 (Clean up E0670 explanation)
 - rust-lang#73440 (Add src/librustdoc as an alias for src/tools/rustdoc)
 - rust-lang#73442 (pretty/mir: const value enums with no variants)
 - rust-lang#73452 (Unify region variables when projecting associated types)
 - rust-lang#73458 (Use alloc::Layout in DroplessArena API)
 - rust-lang#73484 (Update the doc for std::prelude to the correct behavior)
 - rust-lang#73506 (Bump Rustfmt and RLS)

Failed merges:

r? @ghost
@bors bors merged commit 218b90f into rust-lang:master Jun 20, 2020
@lcnr lcnr deleted the common_str branch June 20, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants