Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #72554 #72718

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

estebank
Copy link
Contributor

Fix #72554.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2020
@estebank
Copy link
Contributor Author

estebank commented May 29, 2020

I am not entirely sure this is appropriate, but pushing it out to have somewhere to discuss it.

@estebank estebank force-pushed the impl-trait-obligation-failure branch from 716cb7f to 8595a7e Compare June 1, 2020 16:43
@estebank estebank changed the title Use delay_span_bug on drain_fulfillment_cx_or_panic Add regression test for #72554 Jun 1, 2020
@estebank estebank force-pushed the impl-trait-obligation-failure branch from 8595a7e to eb8d900 Compare June 1, 2020 16:44
@matthewjasper
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 3, 2020

📌 Commit eb8d900 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 3, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 4, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#72718 (Add regression test for rust-lang#72554)
 - rust-lang#72782 (rustc_target: Remove `pre_link_args_crt`)
 - rust-lang#72923 (Improve E0433, so that it suggests missing imports)
 - rust-lang#72950 (fix `AdtDef` docs)
 - rust-lang#72951 (Add Camelid per request)
 - rust-lang#72964 (Bump libc dependency to latest version (0.2.71))

Failed merges:

r? @ghost
@bors bors merged commit 21ac561 into rust-lang:master Jun 4, 2020
@estebank estebank deleted the impl-trait-obligation-failure branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed in erroneous recursive types with methods returning a impl Trait type
4 participants