On recursive ADT, provide indirection structured suggestion #72740

estebank · 2020-05-29T16:26:09Z

No description provided.

rust-highfive · 2020-05-29T16:26:12Z

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2020-05-29T16:27:01Z

src/test/ui/infinite/infinite-tag-type-recursion.stderr

+LL | enum MList { Cons(isize, &MList), Nil }
+   |                          ^


This suggestion isn't entirely correct, but if used the compiler will correctly tell you to write

enum MList<'a> { Cons(isize, &'a MList), Nil }

so I think it is ok.

lcnr · 2020-05-29T17:32:14Z

src/test/ui/issues/issue-17431-4.stderr

+   |
+LL | struct Foo<T> { foo: Box<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }
+   |                      ^^^^                      ^
+LL | struct Foo<T> { foo: Rc<Option<Option<Foo<T>>>>, marker: marker::PhantomData<T> }


These suggestions are now fairly long. While I don't have a strong opinion here, it may be better to only mention Box and & here.

Or thinking more about it, I would prefer if we keep

help: insert indirection (e.g., a Box, Rc, or &) at some point to make Foo representable

and only add an example using Box.

matthewjasper

I'm also a bit concerned by the length of this suggestion.

src/librustc_trait_selection/traits/error_reporting/mod.rs

matthewjasper · 2020-05-31T13:52:18Z

@bors r+

bors · 2020-05-31T13:52:19Z

📌 Commit c209040 has been approved by matthewjasper

…atthewjasper On recursive ADT, provide indirection structured suggestion

RalfJung · 2020-06-06T09:40:56Z

Failed in https://github.com/rust-lang/rust/runs/744866295:

---- [ui] ui/issues/issue-72554.rs stdout ----
diff of stderr:

6	LL |     A(ElemDerived)
7	   |       ----------- recursive without indirection
8	   |
-	   = help: insert indirection (e.g., a `Box`, `Rc`, or `&`) at some point to make `ElemDerived` representable
+	help: insert some indirection (e.g., a `Box`, `Rc`, or `&`) to make `ElemDerived` representable
+	   |
+	LL |     A(Box<ElemDerived>)
+	   |       ^^^^           ^
10	
11	error: aborting due to previous error
12

Probably needs a re-bless.
@bors r-

estebank · 2020-06-10T21:55:55Z

@bors r=matthewjasper rebased

bors · 2020-06-10T21:55:56Z

📌 Commit 03552ec has been approved by matthewjasper

…atthewjasper On recursive ADT, provide indirection structured suggestion

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#72707 (Use min_specialization in the remaining rustc crates) - rust-lang#72740 (On recursive ADT, provide indirection structured suggestion) - rust-lang#72879 (Miri: avoid tracking current location three times) - rust-lang#72938 (Stabilize Option::zip) - rust-lang#73086 (Rename "cyclone" to "apple-a7" per changes in upstream LLVM) - rust-lang#73104 (Example about explicit mutex dropping) - rust-lang#73139 (Add methods to go from a nul-terminated Vec<u8> to a CString) - rust-lang#73296 (Remove vestigial CI job msvc-aux.) - rust-lang#73304 (Revert heterogeneous SocketAddr PartialEq impls) - rust-lang#73331 (extend network support for HermitCore) Failed merges: r? @ghost

rust-highfive assigned matthewjasper May 29, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2020

estebank commented May 29, 2020

View reviewed changes

lcnr reviewed May 29, 2020

View reviewed changes

matthewjasper reviewed May 29, 2020

View reviewed changes

src/librustc_trait_selection/traits/error_reporting/mod.rs Outdated Show resolved Hide resolved

estebank force-pushed the recursive-indirection branch from 9bc1ea2 to c209040 Compare May 31, 2020 02:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2020

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 1, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

ceb26de

…atthewjasper On recursive ADT, provide indirection structured suggestion

RalfJung mentioned this pull request Jun 1, 2020

Rollup of 6 pull requests #72877

Closed

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 6, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

d4a4f16

…atthewjasper On recursive ADT, provide indirection structured suggestion

RalfJung mentioned this pull request Jun 6, 2020

Rollup of 7 pull requests #73052

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2020

estebank added 3 commits June 10, 2020 14:09

On recursive ADT, provide indirection structured suggestion

c29b3fa

review comments: only suggest one substitution

7cde07e

fix rebase

03552ec

estebank force-pushed the recursive-indirection branch from c209040 to 03552ec Compare June 10, 2020 21:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2020

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 11, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

fdf36ff

…atthewjasper On recursive ADT, provide indirection structured suggestion

RalfJung mentioned this pull request Jun 11, 2020

Rollup of 10 pull requests #73231

Closed

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 12, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

35e5dfe

…atthewjasper On recursive ADT, provide indirection structured suggestion

RalfJung mentioned this pull request Jun 12, 2020

Rollup of 5 pull requests #73271

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 12, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

c30ca41

…atthewjasper On recursive ADT, provide indirection structured suggestion

Dylan-DPC-zz mentioned this pull request Jun 12, 2020

Rollup of 6 pull requests #73289

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 13, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

08b8505

…atthewjasper On recursive ADT, provide indirection structured suggestion

Dylan-DPC-zz mentioned this pull request Jun 13, 2020

Rollup of 5 pull requests #73325

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 14, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

f8b99dd

…atthewjasper On recursive ADT, provide indirection structured suggestion

Dylan-DPC-zz mentioned this pull request Jun 14, 2020

Rollup of 5 pull requests #73340

Closed

RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 15, 2020

Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=m…

254c9f0

…atthewjasper On recursive ADT, provide indirection structured suggestion

This was referenced Jun 15, 2020

Rollup of 10 pull requests #73368

Closed

Rollup of 10 pull requests #73369

Merged

bors merged commit d97e8ca into rust-lang:master Jun 15, 2020

estebank deleted the recursive-indirection branch November 9, 2023 05:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On recursive ADT, provide indirection structured suggestion #72740

On recursive ADT, provide indirection structured suggestion #72740

estebank commented May 29, 2020

rust-highfive commented May 29, 2020

estebank May 29, 2020

lcnr May 29, 2020

lcnr May 29, 2020 •

edited

Loading

matthewjasper left a comment

matthewjasper commented May 31, 2020

bors commented May 31, 2020

RalfJung commented Jun 6, 2020

estebank commented Jun 10, 2020

bors commented Jun 10, 2020

On recursive ADT, provide indirection structured suggestion #72740

On recursive ADT, provide indirection structured suggestion #72740

Conversation

estebank commented May 29, 2020

rust-highfive commented May 29, 2020

estebank May 29, 2020

Choose a reason for hiding this comment

lcnr May 29, 2020

Choose a reason for hiding this comment

lcnr May 29, 2020 • edited Loading

Choose a reason for hiding this comment

matthewjasper left a comment

Choose a reason for hiding this comment

matthewjasper commented May 31, 2020

bors commented May 31, 2020

RalfJung commented Jun 6, 2020

estebank commented Jun 10, 2020

bors commented Jun 10, 2020

lcnr May 29, 2020 •

edited

Loading