Skip to content

Update compiler-builtins #72759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2020
Merged

Update compiler-builtins #72759

merged 1 commit into from
May 31, 2020

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented May 29, 2020 •
edited
Loading

Pulls in a fix for #72758, more details on the linked issue.

Crate changes included here

Closes #72758

@alexcrichton
Update compiler-builtins
16469a1 
Pulls in a fix for rust-lang#72758, more details on the linked issue.

[Crate changes included here][changes]

[changes]: rust-lang/compiler-builtins@0.1.28...0.1.31
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2020
@alexcrichton alexcrichton mentioned this pull request May 29, 2020
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

I guess this should get backported to beta ASAP (we promote to stable on monday)? If so we should ping compiler or perhaps @alexcrichton you want to unilaterally approve it?

@bors
Copy link
Collaborator

bors commented May 29, 2020

📌 Commit 16469a1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2020
@alexcrichton
Copy link
Member Author

Looks like beta is using 0.1.27 of compiler-builtins (as opposed to 0.1.28 for master). The one extra version of changes brings in only one other PR, which looks like it should work on beta too.

With that in mind I believe that it should be pretty safe to update the compiler-builtins dependency on beta, so yeah seems like a good backport to me. I do think it's worthwhile to first let this land in this repo though to make sure all the wasm tests pass.

@ehuss
Copy link
Contributor

ehuss commented May 29, 2020

I believe this supersedes #72629.

@JohnTitor JohnTitor mentioned this pull request May 29, 2020
Closed
@bors
Copy link
Collaborator

bors commented May 31, 2020

⌛ Testing commit 16469a1 with merge 4b1f86a...

@bors
Copy link
Collaborator

bors commented May 31, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 4b1f86a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 31, 2020
@bors bors merged commit 4b1f86a into rust-lang:master May 31, 2020
@alexcrichton alexcrichton deleted the update-compiler-builtins branch June 1, 2020 13:40
This was referenced Jun 1, 2020
Closed
Closed
@tmiasko tmiasko mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm with lto and use of f32::sin() gets an unknown reference to env module
5 participants
@alexcrichton @rust-highfive @Mark-Simulacrum @bors @ehuss