Cstring from_raw
and into_raw
safety precisions
#72963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48525.
Fixes #68456.
This issue had two points:
from_raw
has been addressed (I hope).into_raw
, has only been partially fixed.About
into_raw
: the idea was to:I tried making a
Vec<c_char>
like suggested but my current solution feels very unsafe and hacky to me (most notably the type cast), I included it here to make it available for discussion: