Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --expand option to rustc to pretty-print expanded code. #730

Closed
wants to merge 1 commit into from

Conversation

paulstansifer
Copy link
Contributor

No description provided.

@brson brson closed this Jul 23, 2011
pdietl pushed a commit to pdietl/rust that referenced this pull request Apr 23, 2020
…-gate

introduce feature gate into never-type test
tesuji pushed a commit to tesuji/rustc that referenced this pull request Jun 9, 2020
Cleanup: Use rustc's `same_type` for our `same_tys`

This delegates our `same_tys` to [ty::TyS::same_type][same_type] to
remove some duplication.

Our `same_tys` was introduced 4 years ago in rust-lang#730. Before, it was
building an inference context to be able to call
`can_eq` to compare the types. The `rustc-dev-guide` has some more details
about `can_eq` in [Type Inference -> Trying equality][try_eq].

Now, using the rustc function, we are essentially comparing the `DefId`s
of the given types, which also makes more sense, IMO.

I also confirmed that the FIXME is resolved via a bit of `dbg!`, however
no UI tests seem to have been affected.

[same_type]: https://github.com/rust-lang/rust/blob/659951c4a0d7450e43f61c61c0e87d0ceae17087/src/librustc_middle/ty/util.rs#L777
[try_eq]: https://rustc-dev-guide.rust-lang.org/type-inference.html#trying-equality

---

changelog: none
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this pull request Mar 7, 2023
* Bootstrap enzyme tblgen

* Update .packaging/build_tarballs.jl

* Fix tablgen exe

* only set tblgen if empty

* Fix

* Update .packaging/build_tarballs.jl

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>

Co-authored-by: William S. Moses <gh@wsmoses.com>
celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
Add a fixme testcase that can be used to reproduce the issue rust-lang#729.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants