Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #73042

Closed
wants to merge 15 commits into from

Commits on Jun 1, 2020

  1. Configuration menu
    Copy the full SHA
    eaa57cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4e06b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    95e9768 View commit details
    Browse the repository at this point in the history
  2. test: codegen: riscv64-abi: print value numbers for unnamed func args

    LLVM 10 includes a009a60 which will
    print value numbers for unnamed func args.
    
    Update these tests to be in line with the referenced clang tests.
    tblah committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    c872dcf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37e8e05 View commit details
    Browse the repository at this point in the history
  4. test: codegen: skip catch-unwind on riscv64

    It isn't clear to me if this is a bug or not, hence the FIXME
    tblah committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    08529af View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    94605b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. Remove noisy suggestion of hash_map rust-lang#72642

    Fixed failing test-cases
    Ayush Kumar Mishra committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    9d1a883 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2764e54 View commit details
    Browse the repository at this point in the history
  3. Ignore windows in the test.

    pnkfelix committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    a9d5dff View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#72508 - ecstatic-morse:poly-self-ty, r=niko…

    …matsakis
    
    Make `PolyTraitRef::self_ty` return `Binder<Ty>`
    
    This came up during review of rust-lang#71618. The current implementation is the same as a call to `skip_binder` but harder to audit. Make it preserve binding levels and add a call to `skip_binder` at all use sites so they can be audited as part of rust-lang#72507.
    Dylan-DPC committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    365847b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#72952 - pnkfelix:regression-test-for-issue-…

    …70924, r=nikomatsakis
    
    run-make regression test for issue rust-lang#70924.
    
    Sometime after my PR rust-lang#72767 (to fix issue rust-lang#70924) landed, I realized that I *could* make a local regression test, thanks to `rustc --print sysroot`: I can make a fresh "copy" (really mostly symlinks) of the sysroot, and then modify it to recreate the terms of this bug.
    Dylan-DPC committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b8b0ddb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#72977 - tblah:riscv-codegen-llvm10, r=nikom…

    …atsakis
    
    Fix codegen tests for RISC-V
    
    Some codegen tests didn't seem relevant (e.g. unsupported annotations).
    
    The RISC-V abi tests were broken by LLVM 10, c872dcf fixes that (cc: @msizanoen1)
    
    I'm not sure about skipping catch-unwind.rs and included that change here mostly as a request for comment - I can't tell if that's a bug.
    Dylan-DPC committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    9aa792e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73007 - yoshuawuyts:socketaddr-from-string-…

    …u16, r=sfackler
    
    impl ToSocketAddrs for (String, u16)
    
    This adds a convenience impl of `ToSocketAddrs for (String, u16)`. When authoring HTTP services it's common to take command line options for `host` and `port` and parse them into `String` and `u16` respectively. Consider the following program:
    ```rust
    #[derive(Debug, StructOpt)]
    struct Config {
        host: String,
        port: u16,
    }
    
    async fn main() -> io::Result<()> {
        let config = Config::from_args();
        let stream = TcpStream::connect((&*config.host, config.port))?; // &* is not ideal
        // ...
    }
    ```
    
    Networking is a pretty common starting point for people new to Rust, and seeing `&*` in basic examples can be confusing. Even as someone that has experience with networking in Rust I tend to forget that `String` can't be passed directly there. Instead with this patch we can omit the `&*` conversion and pass `host` directly:
    ```rust
    #[derive(Debug, StructOpt)]
    struct Config {
        host: String,
        port: u16,
    }
    
    async fn main() -> io::Result<()> {
        let config = Config::from_args();
        let stream = TcpStream::connect((config.host, config.port))?; // no more conversions!
        // ...
    }
    ```
    
    I think should be an easy and small ergonomics improvement for networking. Thanks!
    Dylan-DPC committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    8954652 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73023 - ayushmishra2005:remove_noisy_sugges…

    …tion, r=davidtwco
    
    Remove noisy suggestion of hash_map
    
    Remove noisy suggestion of hash_map rust-lang#72642
    
    fixes rust-lang#72642
    Dylan-DPC committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    aa99f19 View commit details
    Browse the repository at this point in the history