Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM submodule to include lld NOLOAD fix #73072

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

arcnmx
Copy link
Contributor

@arcnmx arcnmx commented Jun 6, 2020

Rust nightly 2020-05-22 and later ships lld with a regression related to linker scripts: NOLOAD sections incorrectly generate sections filled with 0s. This causes gdb and other elf loaders to write to reserved or otherwise invalid addresses (gdb also seems confused by the resulting ELF files and spits out a warning about the sections). This is particularly a problem for embedded rust projects that use lld by default and have affected linker scripts (cortex-m-rt based projects for instance).

rust-lang/llvm-project#64

Note that this also pulls in llvm changes from #72937

@rust-highfive
Copy link
Collaborator

r? @cuviper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2020
@nikic
Copy link
Contributor

nikic commented Jun 6, 2020

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jun 6, 2020

📌 Commit aa7e771 has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Jun 7, 2020

⌛ Testing commit aa7e771 with merge a2fc33e...

@bors
Copy link
Contributor

bors commented Jun 7, 2020

☀️ Test successful - checks-azure
Approved by: nikic
Pushing a2fc33e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2020
@bors bors merged commit a2fc33e into rust-lang:master Jun 7, 2020
@nikic
Copy link
Contributor

nikic commented Jun 7, 2020

Perf changes for reference: https://perf.rust-lang.org/compare.html?start=450abe80f193ccefbfcd48214d70520f2d507f0e&end=a2fc33e0c87a258542cd12d6ffae52c43aa3785a&stat=instructions:u There's a 1% regression for debug builds.

This is expected from the LVI changes this also pulls in. To mitigate, we can backport https://reviews.llvm.org/D80964 once it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants