Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Spans from HIR -- 2/N -- Small HIR nodes #73094

Closed
wants to merge 31 commits into from
Closed

Remove Spans from HIR -- 2/N -- Small HIR nodes #73094

wants to merge 31 commits into from

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 7, 2020

Second step in rust-lang/compiler-team#294
Builds on #72878
Split out of #72015

This PR gradually removes spans from HIR nodes with low usage.
Along the way, HIR visiting stops passing the spans to the visitor.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
@cjgillot cjgillot mentioned this pull request Jun 7, 2020
Closed
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 7, 2020

r? @ghost , sorry

@petrochenkov petrochenkov removed their assignment Jun 7, 2020
@bors
Copy link
Contributor

bors commented Jun 10, 2020

☔ The latest upstream changes (presumably #72972) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot force-pushed the nospan-small branch 2 times, most recently from 9965b8e to 312c2fb Compare June 23, 2020 08:10
@bors
Copy link
Contributor

bors commented Jun 23, 2020

☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts.

@Muirrum
Copy link
Member

Muirrum commented Jul 9, 2020

@rustbot modify labels to: +S-waiting-on-author -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020
@bors
Copy link
Contributor

bors commented Jul 30, 2020

☔ The latest upstream changes (presumably #74105) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot cjgillot closed this Oct 4, 2020
@cjgillot cjgillot reopened this Dec 13, 2020
@cjgillot cjgillot force-pushed the nospan-small branch 3 times, most recently from 8615229 to 83d33e8 Compare December 13, 2020 19:05
@cjgillot
Copy link
Contributor Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2020
@bors
Copy link
Contributor

bors commented Dec 21, 2020

☔ The latest upstream changes (presumably #80253) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors
Copy link
Contributor

bors commented Dec 25, 2020

☔ The latest upstream changes (presumably #80364) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@cjgillot cjgillot marked this pull request as ready for review December 25, 2020 18:21
@bors
Copy link
Contributor

bors commented Dec 28, 2020

☔ The latest upstream changes (presumably #80439) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 10, 2021

☔ The latest upstream changes (presumably #77862) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2021
@crlf0710
Copy link
Member

crlf0710 commented Mar 5, 2021

Triage: I'll mark this as blocked on #72878 for now.

@crlf0710 crlf0710 added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2021
@cjgillot cjgillot closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @rust-highfive @bors @Muirrum @JohnCSimon @crlf0710 @petrochenkov @rustbot