Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

lcnr and others added 30 commits May 20, 2020 14:57
In particular matching on complex types such as strings will cause
deep recursion to happen.

Fixes rust-lang#72933
Fixes more of:

clippy::unused_unit
clippy::op_ref
clippy::useless_format
clippy::needless_return
clippy::useless_conversion
clippy::bind_instead_of_map
clippy::into_iter_on_ref
clippy::redundant_clone
clippy::nonminimal_bool
clippy::redundant_closure
clippy::option_as_ref_deref
clippy::len_zero
clippy::iter_cloned_collect
clippy::filter_next
`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
Co-authored-by: lzutao <taolzu@gmail.com>
Fix `is_const_context`, update `check_for_cast`

A better version of rust-lang#71477

Adds `fn enclosing_body_owner` and uses it in `is_const_context`.
`is_const_context` now uses the same mechanism as `mir_const_qualif` as it was previously incorrect.
Renames `is_const_context` to `is_inside_const_context`.

I also updated `check_for_cast` in the second commit, so r? @estebank

(I removed one lvl of indentation, so it might be easier to review by hiding whitespace changes)
…i-obk

Ensure stack when building MIR for matches

In particular matching on complex types such as strings will cause
deep recursion to happen.

Fixes rust-lang#72933

r? @matthewjasper @oli-obk
…_doc-ref-fix, r=ollie27

doc/rustdoc: Fix incorrect external_doc feature flag
…ixes, r=Xanewok

save_analysis: better handle paths and functions signature

This should improve slightly some possible regressions due to hir rework.

r? @Xanewok
Fix more clippy warnings

Fixes more of:

clippy::unused_unit
clippy::op_ref
clippy::useless_format
clippy::needless_return
clippy::useless_conversion
clippy::bind_instead_of_map
clippy::into_iter_on_ref
clippy::redundant_clone
clippy::nonminimal_bool
clippy::redundant_closure
clippy::option_as_ref_deref
clippy::len_zero
clippy::iter_cloned_collect
clippy::filter_next

r? @Dylan-DPC
Automatically prioritize unsoundness issues

r? @spastorino cc @Mark-Simulacrum @rust-lang/wg-prioritization
…laumeGomez

Support proc macros in intra doc link resolution

The feature was written pre-proc macro resolution, so it only supported the wacky MBE resolution rules. This adds support for proc macros as well.

cc @GuillaumeGomez

Fixes rust-lang#73173
Fix doctest template

`saturating_add` example was not parameterized, but passed because the `u8` would saturate successfully
@Dylan-DPC-zz
Copy link
Author

@bors r+ p=11 rollup=never

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

📌 Commit ba0a8d2 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 11, 2020
@bors
Copy link
Collaborator

bors commented Jun 11, 2020

⌛ Testing commit ba0a8d2 with merge 50c0192...

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 50c0192 to master...

@rustbot
Copy link
Collaborator

rustbot commented May 2, 2024

Error: Invalid triagebot.toml at position 61:1:

TOML parse error at line 61, column 1
   |
61 | prioritize_on = [
   | ^^^^^^^^^^^^^
unknown field `prioritize_on`, expected `label`

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.