Add/update comments about MinGW late_link_args #73241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Jun 12, 2020
|
Hm, maybe find a reviewer that moth more than absolutely nothing about mingw? I have no way of judging whether your comments make any sense at all.^^ |
|
r=me with the RalfJung's request addressed. |
petrochenkov
added
S-waiting-on-author
mati865
force-pushed
the
mingw-libs-order-comment
branch
from
c062d7e
to
5a841b9
Compare
|
@bors r+ rollup |
|
📌 Commit 5a841b9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 13, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#72932 (Clarify the behaviour of Pattern when used with methods like str::contains) - rust-lang#73066 (Querify whether a type has structural equality (Take 2)) - rust-lang#73194 (Prefer the associated constants for pattern matching error) - rust-lang#73241 (Add/update comments about MinGW late_link_args) - rust-lang#73267 (Use the built cargo for cargotest.) - rust-lang#73290 (Fix links when pinging notification groups) - rust-lang#73302 (Adjusted some doctests in libcore to use `should_panic`.) - rust-lang#73308 (pretty/asm.rs should only be tested for x86_64 and not AArch64) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.