Commits on Jun 15, 2020

1. Avoid prematurely recording toolstates …

   When we're running with dry_run enabled (i.e. all builds do this initially), we're
   guaranteed to save of a toolstate of TestFail for tools that aren't tested. In practice,
   we do test tools as well, so for those tools we would initially record them as being
   TestPass, and then later on re-record the correct state after actually testing them.
   However, this would not work well if the build failed for whatever reason (e.g. panicking
   in bootstrap, or as was the case in 73097, clippy failing to test successfully), we would
   just go on believing that things passed when they in practice did not.
   
   This commit also adjusts saving toolstate to never record clippy explicitly (otherwise, it
   would be recorded when building it); eventually that'll likely move to other tools as well
   but not yet. This is deemed simpler than checking everywhere we generically save
   toolstate.
   
   We also move clippy out of the "toolstate" no-fail-fast build into a separate x.py
   invocation; this should no longer be technically required but provides the nice state of
   letting us check toolstate for all tools and only then check clippy (giving full results
   on every build).

   

   Mark-Simulacrum committed Jun 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 51e11e3
   • Browse repository at this point

   Copy the full SHA

   51e11e3 View commit details

   Browse the repository at this point in the history

2. Disable clippy tests

   

   Mark-Simulacrum committed Jun 15, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 399bf38
   • Browse repository at this point

   Copy the full SHA

   399bf38 View commit details

   Browse the repository at this point in the history