Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_match.rs: fix module doc comment #73341

Merged
merged 1 commit into from
Jun 15, 2020
Merged

_match.rs: fix module doc comment #73341

merged 1 commit into from
Jun 15, 2020

Conversation

jonas-schievink
Copy link
Contributor

It was applied to a use item, not to the module

It was applied to a `use` item, not to the module
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2020
@davidtwco
Copy link
Member

davidtwco commented Jun 14, 2020

r=me when CI passes (I expect it will, but it's possible that some code in doc comments might start being tested and fail)

@Dylan-DPC-zz
Copy link

@bors r=davidtwco rollup

@bors
Copy link
Contributor

bors commented Jun 14, 2020

📌 Commit c7ad3ad has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 15, 2020
_match.rs: fix module doc comment

It was applied to a `use` item, not to the module
This was referenced Jun 15, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#71824 (Check for live drops in constants after drop elaboration)
 - rust-lang#72389 (Explain move errors that occur due to method calls involving `self`)
 - rust-lang#72556 (Fix trait alias inherent impl resolution)
 - rust-lang#72584 (Stabilize vec::Drain::as_slice)
 - rust-lang#72598 (Display information about captured variable in `FnMut` error)
 - rust-lang#73336 (Group `Pattern::strip_*` method together)
 - rust-lang#73341 (_match.rs: fix module doc comment)
 - rust-lang#73342 (Fix iterator copied() documentation example code)
 - rust-lang#73351 (Update E0446.md)
 - rust-lang#73353 (structural_match: non-structural-match ty closures)

Failed merges:

r? @ghost
@bors bors merged commit 35cfde1 into rust-lang:master Jun 15, 2020
@jonas-schievink jonas-schievink deleted the matchdoc branch June 15, 2020 12:16
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants