Record visibility of reexports for all items, not just type items #73365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Yep, that's what I'm doing locally, but I realized that the fix itself was independent of your stuff, it's just that it's impossible to test without your stuff. |
|
Another fix for this might be to not visit hidden modules in the embargo visitor. This might break things. |
GuillaumeGomez
approved these changes
Jun 17, 2020
|
Should we wait for @jyn514's work to be merged first? Otherwise r=me. Thanks @Manishearth ! |
|
Yes, that's what I was saying earlier. We have to wait since the test won't pass otherwise |
Elinvynia
added
S-blocked
27 tasks
rustbot
added
S-waiting-on-author
jyn514
reviewed
Jul 17, 2020
|
@bors r=GuillaumeGomez no need to rebase, bors will handle it |
|
📌 Commit 81641f184639079ea221b32e3ea3712f77112335 has been approved by |
bors
added
S-waiting-on-bors
Did you ever add that test? |
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
|
@bors r=GuillaumeGomez |
|
📌 Commit 90c678c has been approved by |
This was referenced Jul 17, 2020
|
☀️ Test successful - checks-actions, checks-azure |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 24, 2020
…Manishearth Stabilize intra-doc links Fixes rust-lang#43466 Thanks to the great work of @jyn514 in getting the [cross-crate reexport issue](rust-lang#65983) in intra-rustdoc links fixed, I think we're now in a position to stabilize this feature. The tracking issue currently has two unresolved issues: - <s>behavior around doc(hidden): This is fixed in rust-lang#73365, which is just waiting for CI and should land tomorrow. It's also a pretty niche bug so while I expect it to land soon I don't think we need to block stabilization on it anyway.</s> - Non-identifier primitive types like slices: This was not a part of the original RFC anyway, and is a pretty niche use case The feature itself, sans rust-lang#65983, has been shipped on nightly for three years now, with people using it on docs.rs. rust-lang#65983 itself is not an overwhelmingly central bit of functionality; the reason we elected to block stabilization on it was that back in 2017 it was not possible to fix the issue without some major refactorings of resolve, and we did not want to stabilize something that had such a potentially unfixable bug. Given that we've fixed it, I see no reason to delay stabilization on this long awaited feature. It's possible that the latest patches have problems, however we _have_ done crater runs of some of the crucial parts. Furthermore, that's what the release trains are for, we will have a solid three months to let it ride the trains before it actually hits the stable compiler. r? @rust-lang/rustdoc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2020
…nishearth Stabilize intra-doc links Fixes rust-lang#43466 Thanks to the great work of `@jyn514` in getting the [cross-crate reexport issue](rust-lang#65983) in intra-rustdoc links fixed, I think we're now in a position to stabilize this feature. The tracking issue currently has two unresolved issues: - <s>behavior around doc(hidden): This is fixed in rust-lang#73365, which is just waiting for CI and should land tomorrow. It's also a pretty niche bug so while I expect it to land soon I don't think we need to block stabilization on it anyway.</s> - Non-identifier primitive types like slices: This was not a part of the original RFC anyway, and is a pretty niche use case The feature itself, sans rust-lang#65983, has been shipped on nightly for three years now, with people using it on docs.rs. rust-lang#65983 itself is not an overwhelmingly central bit of functionality; the reason we elected to block stabilization on it was that back in 2017 it was not possible to fix the issue without some major refactorings of resolve, and we did not want to stabilize something that had such a potentially unfixable bug. Given that we've fixed it, I see no reason to delay stabilization on this long awaited feature. It's possible that the latest patches have problems, however we _have_ done crater runs of some of the crucial parts. Furthermore, that's what the release trains are for, we will have a solid three months to let it ride the trains before it actually hits the stable compiler. r? `@rust-lang/rustdoc`
jyn514
added
A-intra-doc-links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #73363
Unfortunately I can't add a test for this since this bug is obscured by the cross-crate bug, being fixed in #73363 . Tests will be added later.
cc @jyn514
r? @GuillaumeGomez