Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow later override of forbid lint in same scope #73379

Commits on Aug 18, 2020

  1. rewrite old test so that its attributes are consistent with what we w…

    …ant in the language.
    
    (Note that the fact this test existed is a slight sign that we may need a crater
    run on this bugfix...)
    pnkfelix committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    e24aa73 View commit details
    Browse the repository at this point in the history
  2. When building lint specs map for a given scope, check if forbid prese…

    …nt on each insert.
    
    Drive-by changes:
    
      1. make `LintLevelsBuilder::push` private to the crate.
    
      2. Add methods to `LintSource` for extracting its name symbol or its span.
    pnkfelix committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    01e8e9f View commit details
    Browse the repository at this point in the history
  3. Regression test.

    pnkfelix committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    ef03a5d View commit details
    Browse the repository at this point in the history
  4. review suggestion: use existing defn rather than new intern call

    Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
    pnkfelix and petrochenkov committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    4ec4c4f View commit details
    Browse the repository at this point in the history