- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Mention functions pointers in the documentation #73425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bors
  merged 3 commits into
  rust-lang:master
from
poliorcetics:zeroed-functions-pointers
  
      
      
   
  Jun 19, 2020 
      
    
                
     Merged
            
            Mention functions pointers in the documentation #73425
                    bors
  merged 3 commits into
  rust-lang:master
from
poliorcetics:zeroed-functions-pointers
  
      
      
   
  Jun 19, 2020 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override)  | 
    
5c54796    to
    15cd51a      
    Compare
  
    
              
                    dtolnay
  
              
              requested changes
              
                  
                    Jun 16, 2020 
                  
              
              
            
            
Co-authored-by: David Tolnay <dtolnay@gmail.com>
              
                    dtolnay
  
              
              approved these changes
              
                  
                    Jun 18, 2020 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| 
           @bors r+ rollup  | 
    
| 
           📌 Commit 2da9ca7 has been approved by   | 
    
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      Jun 18, 2020 
    
    
      
  
    
      
    
  
…ers, r=dtolnay Mention functions pointers in the documentation Fixes rust-lang#51615. This mentions function pointers in the documentation for `core::mem::zeroed`, adding them to the list of types that are **always** wrong when zeroed, with `&T` and `&mut T`. @rustbot modify labels: T-doc, C-enhancement, T-libs
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Jun 19, 2020 
    
    
      
  
    
      
    
  
…arth Rollup of 17 pull requests Successful merges: - rust-lang#70551 (Make all uses of ty::Error delay a span bug) - rust-lang#71338 (Expand "recursive opaque type" diagnostic) - rust-lang#71976 (Improve diagnostics for `let x += 1`) - rust-lang#72279 (add raw_ref macros) - rust-lang#72628 (Add tests for 'impl Default for [T; N]') - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position) - rust-lang#72814 (remove visit_terminator_kind from MIR visitor) - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS) - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved) - rust-lang#73034 (Export `#[inline]` fns with extern indicators) - rust-lang#73315 (Clean up some weird command strings) - rust-lang#73320 (Make new type param suggestion more targetted) - rust-lang#73361 (Tweak "non-primitive cast" error) - rust-lang#73425 (Mention functions pointers in the documentation) - rust-lang#73428 (Fix typo in librustc_ast docs) - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods) - rust-lang#73476 (Added tooltip for should_panic code examples) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-docs
  Area: Documentation for any part of the project, including the compiler, standard library, and tools 
  
    C-enhancement
  Category: An issue proposing an enhancement or a PR with one. 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-libs-api
  Relevant to the library API team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #51615.
This mentions function pointers in the documentation for
core::mem::zeroed, adding them to the list of types that are always wrong when zeroed, with&Tand&mut T.@rustbot modify labels: T-doc, C-enhancement, T-libs