Move remaining NodeId
APIs from Definitions
to Resolver
#73587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #73291 (comment)
TL;DR: it moves all fields that are only needed during name resolution passes into the
Resolver
and keep the rest inDefinitions
. This effectively enforces that all references toNodeId
s are gone once HIR lowering is completed.After this, the only remaining work for #50928 should be to adjust the dev guide.
r? @petrochenkov