Use 'tcx for references to AccessLevels wherever possible. #73753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
r=me, as I understand it the last commit just removes the lifetime parameter from LateContext, yes? |
|
@Manishearth Those are the changes in |
This comment has been minimized.
This comment has been minimized.
eddyb
force-pushed
the
extraneous-lifetime
branch
3 times, most recently
from
a1cce6e
to
bcdc482
Compare
eddyb
force-pushed
the
extraneous-lifetime
branch
from
bcdc482
to
874f406
Compare
|
@bors r=Manishearth |
|
📌 Commit 874f406 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2020
…arth Rollup of 8 pull requests Successful merges: - rust-lang#73454 (Move contributing.md to rustc-dev-guide and point at getting started) - rust-lang#73724 (Use WASM's saturating casts if they are available) - rust-lang#73726 (resolve: disallow labelled breaks/continues through closures/async blocks) - rust-lang#73753 (Use 'tcx for references to AccessLevels wherever possible.) - rust-lang#73781 (Update psm version) - rust-lang#73952 (Add option for local docker testing.) - rust-lang#73957 (disable BTree min_max test in Miri for now) - rust-lang#73975 (Document rustc_ast::ast::Pat) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are just fallout from removing a lifetime parameter from structs, and mostly in clippy.
r? @Manishearth