Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #73830

Merged
merged 38 commits into from
Jun 28, 2020
Merged

Rollup of 10 pull requests #73830

merged 38 commits into from
Jun 28, 2020

Commits on Jun 11, 2020

  1. Configuration menu
    Copy the full SHA
    93cbad6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec63f9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1243db View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Configuration menu
    Copy the full SHA
    810f309 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50d7dea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93e3552 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9576e30 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8200771 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    978470f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    91f73fb View commit details
    Browse the repository at this point in the history
  8. fix typo

    Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
    RalfJung and lcnr committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    7754322 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7f8fe6a View commit details
    Browse the repository at this point in the history
  10. expand a comment

    RalfJung committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    5e5ae8b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a593728 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Configuration menu
    Copy the full SHA
    35911ee View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Adds a clearer message for when the async keyword is missing from a f…

    …unction
    
    Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
    nellshamrell committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    5e28eb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2020

  1. Prepare for LLVM 11

    cuviper committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    49f6166 View commit details
    Browse the repository at this point in the history
  2. improper_ctypes: fix remaining Reveal:All

    This commit replaces the remaining uses of `ParamEnv::reveal_all` with
    `LateContext`'s `param_env` (normally `Reveal::UserFacing`).
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a6417b9 View commit details
    Browse the repository at this point in the history
  3. errors: use -Z terminal-width in JSON emitter

    This commit makes the JSON emitter use `-Z terminal-width` in the
    "rendered" field of the JSON output.
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    3678e5c View commit details
    Browse the repository at this point in the history
  4. Make fn_arg_names return Ident instead of symbol

    Also, implement this query for the local crate, not just foreign crates.
    Aaron1011 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    36ac08e View commit details
    Browse the repository at this point in the history
  5. Explain move errors that occur due to method calls involving self

    This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594)
    Instead of using `ExpnKind::Desugaring` to represent operators, this PR
    checks the lang item directly.
    Aaron1011 committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    fa6a61c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. Configuration menu
    Copy the full SHA
    a4e7b47 View commit details
    Browse the repository at this point in the history
  2. more LocalDefId in ty::context

    lcnr committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    1875c79 View commit details
    Browse the repository at this point in the history
  3. more LocalDefId cleanup

    lcnr committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    2d280a5 View commit details
    Browse the repository at this point in the history
  4. fix typo in self-profile.md

    atetubou authored Jun 27, 2020
    Configuration menu
    Copy the full SHA
    9308860 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d25d6c5 View commit details
    Browse the repository at this point in the history
  6. Add links to fs::DirEntry::metadata

    `fs::DirEntry::metadata` doesn't traverse symlinks. It is not immediately
    clear what to do if you do want to traverse symlinks. This change adds
    links to the two other `metadata` functions that will follow symlinks.
    robyoung committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    0e0584f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8e8c54a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Rollup merge of rust-lang#72796 - RalfJung:mir-assign-sanity, r=matth…

    …ewjasper
    
    MIR sanity check: validate types on assignment
    
    This expands the MIR validation added by @jonas-schievink in rust-lang#72093 to also check that on an assignment, the types of both sides match.
    
    Cc @eddyb @oli-obk
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    385d85c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#73243 - poliorcetics:discourage-is-file, r=…

    …Amanieu
    
    Add documentation to point to `File::open` or `OpenOptions::open` instead of `is_file` to check read/write possibility
    
    Fixes rust-lang#64170.
    
    This adds documentation to point user towards `!is_dir` instead of `is_file` when all they want to is read from a source.
    
    I ran `rg "fn is_file\("` to find all `is_file` methods, I hope I did not miss one.
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    6a944c1 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#73525 - cuviper:llvm11, r=nikic

    Prepare for LLVM 11
    
    These are just the code changes needed to build with the current LLVM master (version 11).
    
    r? @nikic
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    45ec25e View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#73672 - nellshamrell:async-fix, r=estebank

    Adds a clearer message for when the async keyword is missing from a f…
    
    …unction
    
    This is a somewhat simple fix for rust-lang#66731.
    
    Under the current version of Rust, if a user has a rust file that looks like this:
    
    ```rust
    fn boo (){}
    
    async fn foo() {
        boo().await;
    }
    
    fn main() {
    
    }
    ```
    
    And they attempt to run it, they will receive an error message that looks like this:
    
    ```bash
    error: incorrect use of `await`                                                                                                        --> test.rs:4:14                                                                                                                       |                                                                                                                                   4 |     boo.await();                                                                                                                    |              ^^ help: `await` is not a method call, remove the parentheses                                                                                                                                                                                              error[E0277]: the trait bound `fn() {boo}: std::future::Future` is not satisfied                                                        --> test.rs:4:5                                                                                                                        |                                                                                                                                  4  |     boo.await();                                                                                                                    |     ^^^^^^^^^ the trait `std::future::Future` is not implemented for `fn() {boo}`                                                                                                                                                                                      error: aborting due to 2 previous errors                                                                                                                                                                                                                                    For more information about this error, try `rustc --explain E0277`.
    ```
    
    This is not very clear.
    
    With the changes made in this PR, when a user compiles and runs that same rust code, they will receive an error message that looks like this:
    
    ```bash
    error[E0277]: `()` is not a future.
     --> test.rs:4:5
      |
    4 |     boo().await;
      |     ^^^^^^^^^^^ `()` is not a future
      |
      = help: the trait `std::future::Future` is not implemented for `()`
      = note: required by `std::future::Future::poll`
    ```
    
    In the future, I think we should make this error message even clearer, perhaps through a solution like the one described in [this comment](rust-lang#66731 (comment)). However, as that potentially involves a major change proposal, I would rather get this change in now and make the error message a little clearer while an MCP is drafted and discussed.
    
    Signed-off-by: Nell Shamrell <nellshamrell@gmail.com>
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    d227a82 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#73708 - Aaron1011:feature/reland-move-fn-se…

    …lf-msg, r=davidtwco
    
    Explain move errors that occur due to method calls involving `self` (take two)
    
    This is a re-attempt of rust-lang#72389 (which was reverted in rust-lang#73594)
    Instead of using `ExpnKind::Desugaring` to represent operators, this PR
    checks the lang item directly.
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    b236e49 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#73758 - davidtwco:issue-60855-remaining-rev…

    …eal-all, r=matthewjasper
    
    improper_ctypes: fix remaining `Reveal:All`
    
    Fixes rust-lang#60855.
    
    This PR replaces the remaining uses of `ParamEnv::reveal_all` with `LateContext`'s `param_env` (normally `Reveal::UserFacing`) in the improper ctypes lint.
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    d5205f2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#73763 - davidtwco:terminal-width-json-emitt…

    …er, r=estebank
    
    errors: use `-Z terminal-width` in JSON emitter
    
    This PR makes the JSON emitter use `-Z terminal-width` in the "rendered" field of the JSON output.
    
    r? @estebank
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    596af5a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#73796 - lcnr:LocalDefId, r=matthewjasper

    replace more `DefId`s with `LocalDefId`
    
    part of rust-lang#70853
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    800d2e3 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#73797 - atetubou:patch-1, r=jonas-schievink

    fix typo in self-profile.md
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    dc843a8 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#73809 - robyoung:docs/add-links-to-DirEntry…

    …-metadata, r=hanna-kruppe
    
    Add links to fs::DirEntry::metadata
    
    `fs::DirEntry::metadata` doesn't traverse symlinks. It is not immediately clear what to do if you do want to traverse symlinks. This change adds links to the two other `metadata` functions that will follow symlinks.
    Manishearth authored Jun 28, 2020
    Configuration menu
    Copy the full SHA
    cdb59d9 View commit details
    Browse the repository at this point in the history