Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unwrap_or_else in RawVec::allocate_in. #73882

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Avoid unwrap_or_else in RawVec::allocate_in. #73882

merged 1 commit into from
Jul 3, 2020

Conversation

nnethercote
Copy link
Contributor

This reduces the amount of LLVM IR generated by up to 1 or 2%.

r? @Amanieu

@nnethercote
Avoid unwrap_or_else in RawVec::allocate_in.
3f79d2f 
This reduces the amount of LLVM IR generated by up to 1 or 2%.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2020
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@nnethercote
Copy link
Contributor Author

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jun 30, 2020

⌛ Trying commit 3f79d2f with merge 1a70453c35125c6657c8e370c6f497f9ec9c41c9...

@bors
Copy link
Contributor

bors commented Jun 30, 2020

☀️ Try build successful - checks-azure
Build commit: 1a70453c35125c6657c8e370c6f497f9ec9c41c9 (1a70453c35125c6657c8e370c6f497f9ec9c41c9)

@rust-timer
Copy link
Collaborator

Queued 1a70453c35125c6657c8e370c6f497f9ec9c41c9 with parent a1528c4, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (1a70453c35125c6657c8e370c6f497f9ec9c41c9): comparison url.

@Amanieu
Copy link
Member

Amanieu commented Jun 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2020

📌 Commit 3f79d2f has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2020
@nnethercote
Copy link
Contributor Author

The CI run shows small but clear benefits of up to 1% across numerous benchmarks.

@Manishearth
Copy link
Member

@bors p=1

@bors
Copy link
Contributor

bors commented Jul 1, 2020

⌛ Testing commit 3f79d2f with merge ea4a9c72845bbea7462e3fddff0e7a19c9ec6bb1...

@Manishearth
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2020
@Manishearth Manishearth closed this Jul 1, 2020
@Manishearth Manishearth reopened this Jul 1, 2020
@Manishearth
Copy link
Member

@bors r=Amanieu retry

yielding to rollup

@ecstatic-morse
Copy link
Contributor

@bors r=Amanieu

(@Manishearth I think "retry" retried the r-?)

@ecstatic-morse
Copy link
Contributor

Or maybe bors is just borked? This still isn't in the queue.

@mati865
Copy link
Contributor

mati865 commented Jul 1, 2020

Maybe closing the PR while it was tested has broke bors?

@ecstatic-morse
Copy link
Contributor

@bors r-

@ecstatic-morse ecstatic-morse reopened this Jul 1, 2020
@ecstatic-morse
Copy link
Contributor

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Jul 1, 2020

📌 Commit 3f79d2f has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2020
@Manishearth
Copy link
Member

yeah bors has been acting weird, the yield feature is broken too

@bors
Copy link
Contributor

bors commented Jul 1, 2020

⌛ Testing commit 3f79d2f with merge 1462072fca19e34db73be4155857a097c17b92aa...

@Manishearth
Copy link
Member

@bors retry yield

@Manishearth
Copy link
Member

I'll be letting rollup=nevers filter through soon enough

@bors
Copy link
Contributor

bors commented Jul 3, 2020

⌛ Testing commit 3f79d2f with merge cd1a46d...

@bors
Copy link
Contributor

bors commented Jul 3, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing cd1a46d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2020
@bors bors merged commit cd1a46d into rust-lang:master Jul 3, 2020
@nnethercote nnethercote deleted the avoid-unwrap_or_else-in-allocate_in branch July 3, 2020 08:08
@nnethercote
Copy link
Contributor Author

Perf results show a win, as expected.

@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
9 participants
@nnethercote @rust-timer @bors @Amanieu @Manishearth @ecstatic-morse @mati865 @cuviper @rust-highfive