Rewrite each path #7396
Closed
Rewrite each path #7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ Please feel free to set this as high priority. |
This is the backwards-incompatible part of per-binding-site "mut".
…ff trans, I think?
They evaluated the receiver twice. They should be added back with `AddAssign`, `SubAssign`, etc., traits.
…mplementations. This should allow fewer symbols to be exported.
Instead of determining paths from the path tag, we iterate through modules' children recursively in the metadata. This will allow for lazy external module resolution.
|
I've fixed the test and opened my own PR. |
Closed
|
I've fixed the test and opened my own PR. #7451 |
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 1, 2021
Fix invocation of `zst_offset` lint The `zst_offset` lint was broken by a refactoring regression in 2108387. In the invocation of the `zst_offset` check [here](rust-lang/rust-clippy@2108387#diff-7f73f6fe28c04b654223c09c42fe02937d2351fc58a91d21ab812aaf6f9b185dR1927), we shadow the already-destructured receiver `recv`, and accidentally pass the first argument of the method as if it were the receiver. This was not caught because the UI test expectation was never correct (a bad cast obscured the actual test result). This PR: - Fixes the existing test expectation - Tests both `const` and `mut` raw pointers - Passes the actual receiver to the lint's implementation Fixes rust-lang#7395. changelog: Fix [`zst_offset`] invocation and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis