Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit docs for rustc_data_structures::graph::scc #73984

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Edit docs for rustc_data_structures::graph::scc #73984

merged 1 commit into from
Jul 4, 2020

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Jul 3, 2020

  • Add newline to provide concise module summary
  • Add wikipedia link
  • Italicize O notation

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2020
@pierwill
Edit docs for rustc_data_structures::graph::scc
20caf63 
- Add newline to provide concise module summary
- Add wikipedia link
- Italicize O notation
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit 20caf63 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2020
@Manishearth Manishearth mentioned this pull request Jul 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2020
@bors
Auto merge of rust-lang#74019 - Manishearth:rollup-2st3jsk, r=Manishe…
dbf3ae7 
…arth

Rollup of 12 pull requests

Successful merges:

 - rust-lang#73140 (Fallback to xml.etree.ElementTree)
 - rust-lang#73670 (Add `format_args_capture` feature)
 - rust-lang#73693 (Use exhaustive match in const_prop.rs)
 - rust-lang#73845 (Use &raw in A|Rc::as_ptr)
 - rust-lang#73861 (Create E0768)
 - rust-lang#73881 (Standardize bibliographic citations in rustc API docs)
 - rust-lang#73925 (Improve comments from rust-lang#72617, as suggested by RalfJung)
 - rust-lang#73949 ([mir-opt] Fix mis-optimization and other issues with the SimplifyArmIdentity pass)
 - rust-lang#73984 (Edit docs for rustc_data_structures::graph::scc)
 - rust-lang#73985 (Fix "getting started" link)
 - rust-lang#73997 (fix typo)
 - rust-lang#73999 (Bump mingw-check CI image from Ubuntu 16.04 to 18.04.)

Failed merges:

 - rust-lang#74000 (add `lazy_normalization_consts` feature gate)

r? @ghost
@bors bors merged commit 70c4b2f into rust-lang:master Jul 4, 2020
@pierwill pierwill deleted the pierwill-tarjan branch December 23, 2020 00:55
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink Awaiting requested review from jonas-schievink

Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@pierwill @rust-highfive @jonas-schievink @bors @cuviper @matthewjasper