Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "getting started" link #73985

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Fix "getting started" link #73985

merged 1 commit into from
Jul 4, 2020

Conversation

e00E
Copy link
Contributor

@e00E e00E commented Jul 3, 2020

The previous link is 404.

@e00E
Fix "getting started" link
df43dcd 
The previous link is 404.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2020
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 3, 2020

📌 Commit df43dcd has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2020
@jonas-schievink
Copy link
Contributor

Thanks!

@jonas-schievink jonas-schievink mentioned this pull request Jul 3, 2020
Closed
@bors
Copy link
Contributor

bors commented Jul 3, 2020

⌛ Testing commit df43dcd with merge 21baf0352e2571802f5f888bec56351c56fc5c83...

@bors bors mentioned this pull request Jul 3, 2020
Merged
@pietroalbini
Copy link
Member

@bors treeclosed-

@bors
Copy link
Contributor

bors commented Jul 3, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2020
@pietroalbini
Copy link
Member

@bors retry #71988

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2020
This was referenced Jul 3, 2020
Closed
Closed
Closed
Closed
@Fasani Fasani mentioned this pull request Jul 3, 2020
Closed
@mark-i-m
Copy link
Member

mark-i-m commented Jul 3, 2020

Oops! Thanks @e00E

@Manishearth Manishearth mentioned this pull request Jul 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2020
@bors
Auto merge of rust-lang#74019 - Manishearth:rollup-2st3jsk, r=Manishe…
dbf3ae7 
…arth

Rollup of 12 pull requests

Successful merges:

 - rust-lang#73140 (Fallback to xml.etree.ElementTree)
 - rust-lang#73670 (Add `format_args_capture` feature)
 - rust-lang#73693 (Use exhaustive match in const_prop.rs)
 - rust-lang#73845 (Use &raw in A|Rc::as_ptr)
 - rust-lang#73861 (Create E0768)
 - rust-lang#73881 (Standardize bibliographic citations in rustc API docs)
 - rust-lang#73925 (Improve comments from rust-lang#72617, as suggested by RalfJung)
 - rust-lang#73949 ([mir-opt] Fix mis-optimization and other issues with the SimplifyArmIdentity pass)
 - rust-lang#73984 (Edit docs for rustc_data_structures::graph::scc)
 - rust-lang#73985 (Fix "getting started" link)
 - rust-lang#73997 (fix typo)
 - rust-lang#73999 (Bump mingw-check CI image from Ubuntu 16.04 to 18.04.)

Failed merges:

 - rust-lang#74000 (add `lazy_normalization_consts` feature gate)

r? @ghost
@bors bors merged commit e4c505b into rust-lang:master Jul 4, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
8 participants
@e00E @rust-highfive @jonas-schievink @bors @pietroalbini @mark-i-m @cuviper @nikomatsakis