Support for Harvey. Harvey is Plan 9 with GPL. #74038
Conversation
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
If you think I don't know what I'm doing, you're right, but my pattern is learn by mistaking. :-) |
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Derived from Linux, with dynamic linking set to false and elf TLS set to false (not sure on that second one). Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
|
Does anyone have opinions on this @rust-lang/compiler ? |
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
|
Just FYI, once this is in, the sum total of system calls is 52, many of them being identical to Linux. When we started Harvey we made sure our system call convention followed the ABI, just to make compiler addition easy. Thanks for the super-fast review :-) |
|
“Harvey is Plan 9 with GPL” except that it isn't 😛 |
? |
|
ah I get it ... I mean Harvey moved to the the system v ABI system call interface, i.e. we use the sysv abi for x86_64, not the plan 9 one. The plan 9 one was stack-based, as still used in Go today. |
|
I'll give everyone a bit more time to comment on this before merging. Could you leave some contact info (urls to repos or other related webpages) in the architecture files? |
|
The main thing I would like, yes, is that I think we need some idea who to ping to notify of things related to this architecture. I don't have any objection to adding as a new Tier 3 platform. |
|
☔ The latest upstream changes (presumably #74662) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rminnich This PR needs rebasing and some contact info in case we need some help around the Harvey architecture. Then it can be merged. |
|
@rminnich Ping from triage! This hasn't seen much activity recently. Could you address the comments above? Thanks! |
jyn514
added
S-waiting-on-author
|
@rminnich Ping from triage! I'm closing this due to inactivity. Feel free to reopen or create a new PR when you've got time to work on this again! Thanks! |
crlf0710
added
S-inactive
Signed-off-by: Ronald G. Minnich rminnich@gmail.com