Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap: reorder tools to properly reflect their build order #74128

Closed
wants to merge 1 commit into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jul 7, 2020

Noticed in #74016 (comment)

RLS depends on Clippy and Rustfmt.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2020
@mati865
Copy link
Contributor Author

mati865 commented Jul 7, 2020

Also cc @ehuss

@Mark-Simulacrum
Copy link
Member

I don't have time to repeat @ehuss' investigative work here, so let's r? @ehuss

@ehuss
Copy link
Contributor

ehuss commented Jul 8, 2020

This doesn't actually change the order, at least for x.py dist. The order is defined by the Extended step.

Although changing the order can help a little, I still think it is more important to merge #74046, which should significantly reduce the rebuilds.

It looks like rust-analyzer is also causing some issues, I'm going to investigate that more.

@mati865
Copy link
Contributor Author

mati865 commented Jul 8, 2020

Order in get_step_descriptions matters for test subcommand and I assumed dist would also follow it. Sorry for the noise.

@mati865 mati865 closed this Jul 8, 2020
@mati865 mati865 deleted the tools-build-order branch August 12, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants