Std panicking unsafe block in unsafe fn #74200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
22 tasks
crlf0710
added
S-waiting-on-review
shepmaster
reviewed
Jul 27, 2020
poliorcetics
force-pushed
the
std-panicking-unsafe-block-in-unsafe-fn
branch
from
5fc0e08 to
2292064
Compare
|
@Mark-Simulacrum the last commit made the |
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me with a rebase |
poliorcetics
force-pushed
the
std-panicking-unsafe-block-in-unsafe-fn
branch
from
12fec55 to
a39aae8
Compare
|
Rebase done, checks are in progress. 😃 |
|
Please also squash all commits into one. |
This adds SAFETY comments where necessary, explaining the preconditions and how they are respected.
poliorcetics
force-pushed
the
std-panicking-unsafe-block-in-unsafe-fn
branch
from
a39aae8 to
82ccdab
Compare
|
@bors r=Mark-Simulacrum rollup |
|
📌 Commit 82ccdab has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 10, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74200 (Std panicking unsafe block in unsafe fn) - rust-lang#75286 (Add additional case for Path starts with) - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope) - rust-lang#75320 (Detect likely `for foo of bar` JS syntax) - rust-lang#75328 (Cleanup E0749) - rust-lang#75344 (Rename "Important traits" to "Notable traits") - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs) - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #73904.
This encloses
unsafeoperations inunsafe fninlibstd/ffi/panicking.rs.I also made a two lines change to
libstd/thread/local.rsto add the necessaryunsafeblock without breaking everything else.@rustbot modify labels: F-unsafe-block-in-unsafe-fn