Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 18 pull requests #74303

Closed
wants to merge 77 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
37570e8
Substantial refactor to the design of LineWriter
Lucretiel May 29, 2020
0f38158
Updated comments; only pre-flush newline terminated buffers
Lucretiel May 31, 2020
4a1597f
Expressionify `LineWriterShim::write`
Lucretiel May 31, 2020
5edad37
Expressionify write_all
Lucretiel May 31, 2020
1bf8ba3
x.py fmt
Lucretiel May 31, 2020
e0dfdc6
Added check for `is_write_vectored`
Lucretiel Jun 1, 2020
2c3024b
Add comment describing erroneous_flush_retried
Lucretiel Jun 1, 2020
e89e2e4
Added test stubs
Lucretiel Jun 1, 2020
f0a0807
Various testing & implementation updates:
Lucretiel Jun 1, 2020
b6296e8
Tons of testing updates, other minor changes
Lucretiel Jun 2, 2020
e022d34
Fixed typo in test
Lucretiel Jun 2, 2020
e4328ae
Code review updates: all minor style fixes
Lucretiel Jun 2, 2020
f7650fe
Add comment
Lucretiel Jun 2, 2020
7a6a12b
Tidy fixes
Lucretiel Jun 2, 2020
338a2c0
Reimplement flush_buf with a Guard. Longer, but cleaner.
Lucretiel Jun 2, 2020
c869638
Added comment about BufWrite::write_all
Lucretiel Jun 2, 2020
61f591e
Improved line_vectored_ignored. Added stylistic semicolon.
Lucretiel Jun 2, 2020
2d22c77
Fixed bug in write_vectored & empty buffers
Lucretiel Jun 2, 2020
2c23b90
Comment updates
Lucretiel Jun 2, 2020
e999ca5
Remove inline from write_to_buf
Lucretiel Jun 2, 2020
70ba320
More minor changes
Lucretiel Jun 2, 2020
5b1a40c
BufWriter::write* methods now use fewer runtime checks
Lucretiel Jun 2, 2020
8df5ae0
x.py fix AGAIN
Lucretiel Jun 2, 2020
60ab99f
Fixed corner case related to partial-line buffering
Lucretiel Jun 2, 2020
38017a3
Update comments with relevant issue numbers
Lucretiel Jun 2, 2020
59710fb
Clarified comment in `partial_multiline_buffering` test
Lucretiel Jun 2, 2020
2e21af2
Document the union keyword
poliorcetics Jun 29, 2020
614f773
Clarify some parts by applying the suggestions from review
poliorcetics Jun 30, 2020
310c97b
Fix caching issue when building tools.
ehuss Jul 4, 2020
c478b54
add as_ptr method to raw slices
RalfJung Jul 3, 2020
3b1d5e6
call the mut version as_mut_ptr and also add an as_ptr-like method to…
RalfJung Jul 3, 2020
90580c7
make unchecked slice indexing helper methods use raw pointers
RalfJung Jul 5, 2020
5f5c98b
add (unchecked) indexing methods to raw pointers and NonNull
RalfJung Jul 5, 2020
00980b6
clean up E0718 explanation
GuillaumeGomez Jul 7, 2020
c8b16cd
rustdoc: Allow linking from private items to private types
dennis-hamester Jul 8, 2020
23d7b3f
Remove an unwrap in layout computation
erikdesjardins Jul 10, 2020
689e360
test: rustdoc-ui: Add issue-74134, replacing test/rustdoc/issue-74134-*
dennis-hamester Jul 11, 2020
b8632e1
Removed FIXME
Lucretiel Jul 11, 2020
140bfc5
Removed another FIXME
Lucretiel Jul 11, 2020
9704859
test: rustdoc-ui: Expand issue-74134 to cover types in a private module
dennis-hamester Jul 11, 2020
8789525
test: rustdoc-ui: issue-74134: Shorten a too long line
dennis-hamester Jul 11, 2020
0979545
rustdoc: insert newlines between attributes
euclio Jun 28, 2020
4728438
Improve wording
GuillaumeGomez Jul 11, 2020
997accc
Remove doubled "is_write_vectored"
Lucretiel Jul 11, 2020
6a7b5df
Removed unused method
Lucretiel Jul 11, 2020
905b5ad
don't mark linux kernel module targets as a unix environment
alex Jul 11, 2020
606593f
Minor updates
Lucretiel Jul 12, 2020
8082fb9
rename fast_thread_local -> thread_local_dtor; thread_local -> thread…
RalfJung Jul 12, 2020
7dc3886
adjust remaining targets
RalfJung Jul 12, 2020
ff5e107
assign tracking issue
RalfJung Jul 12, 2020
d512a6c
Don't panic if the lhs of a div by zero is not statically known
oli-obk Jul 10, 2020
5afbc52
typeck: report placeholder type error w/out span
davidtwco Jul 12, 2020
5daedea
Detect tuple struct incorrectly used as struct pat
estebank Jul 9, 2020
ffac887
Update RELEASES.md for 1.45.0
XAMPPRocky Jun 14, 2020
ed587f8
Update llvm-project to latest origin/rustc/10.0-2020-05-05 commit whi…
AdrianCX Jul 11, 2020
c24b96d
Teach bootstrap about target files vs target triples
shepmaster Jul 2, 2020
e3ae4c7
Added proper explanation of ErrorCode-E0688
Polkaverse Jul 13, 2020
bc2b37a
Merge branch 'master' into E0688
Polkaverse Jul 13, 2020
b78dd15
:arrow_up: rust-analyzer
matklad Jul 13, 2020
6253a30
Rollup merge of #72808 - Lucretiel:line-writer-reimpl, r=Amanieu
Manishearth Jul 13, 2020
404542d
Rollup merge of #73354 - XAMPPRocky:relnotes-1.45.0, r=Mark-Simulacrum
Manishearth Jul 13, 2020
331179c
Rollup merge of #73852 - euclio:rustdoc-attr-newlines, r=GuillaumeGomez
Manishearth Jul 13, 2020
273444e
Rollup merge of #73867 - poliorcetics:union-keyword, r=joshtriplett
Manishearth Jul 13, 2020
172b65f
Rollup merge of #73986 - RalfJung:raw-slice-as-ptr, r=sfackler
Manishearth Jul 13, 2020
ab63c08
Rollup merge of #74046 - ehuss:deny-warnings-caching, r=Mark-Simulacrum
Manishearth Jul 13, 2020
3239e02
Rollup merge of #74123 - GuillaumeGomez:cleanup-e0718, r=pickfire
Manishearth Jul 13, 2020
27a1353
Rollup merge of #74147 - dennis-hamester:fix/issue-74134, r=jyn514
Manishearth Jul 13, 2020
2b6cecd
Rollup merge of #74173 - estebank:struct-pat-as-enum, r=petrochenkov
Manishearth Jul 13, 2020
350b9cf
Rollup merge of #74221 - oli-obk:const_prop_ice, r=wesleywiser
Manishearth Jul 13, 2020
1909471
Rollup merge of #74227 - erikdesjardins:layun, r=estebank
Manishearth Jul 13, 2020
fe08950
Rollup merge of #74239 - AdrianCX:master, r=cuviper
Manishearth Jul 13, 2020
8284439
Rollup merge of #74251 - shepmaster:bootstrap-target-files, r=Mark-Si…
Manishearth Jul 13, 2020
279e1fb
Rollup merge of #74257 - alex:patch-1, r=joshtriplett
Manishearth Jul 13, 2020
79dc404
Rollup merge of #74263 - RalfJung:thread-local, r=Mark-Simulacrum
Manishearth Jul 13, 2020
c010339
Rollup merge of #74270 - davidtwco:issue-74086-more-placeholder-type-…
Manishearth Jul 13, 2020
b1c931d
Rollup merge of #74286 - PankajChaudhary5:E0688, r=GuillaumeGomez
Manishearth Jul 13, 2020
5b2adeb
Rollup merge of #74290 - matklad:rust-analyzer-2020-07-13, r=matklad
Manishearth Jul 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove inline from write_to_buf
Lucretiel committed Jun 2, 2020
commit e999ca5ac3a21183fdc8cc99350752d0f1ef0bdd
1 change: 0 additions & 1 deletion src/libstd/io/buffered.rs
Original file line number Diff line number Diff line change
@@ -597,7 +597,6 @@ impl<W: Write> BufWriter<W> {
/// Buffer some data without flushing it, regardless of the size of the
/// data. Writes as much as possible without exceeding capacity. Returns
/// the number of bytes written.
#[inline]
fn write_to_buf(&mut self, buf: &[u8]) -> usize {
let available = self.buf.capacity() - self.buf.len();
let amt_to_buffer = available.min(buf.len());