Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Symbol related improvements #74357

Merged
merged 6 commits into from
Jul 17, 2020
Merged

Some Symbol related improvements #74357

merged 6 commits into from
Jul 17, 2020

Conversation

nnethercote
Copy link
Contributor

These commits make things nicer and avoid some Symbol::as_str() calls.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jul 15, 2020

r=me with documentation nit resolved.

@nnethercote nnethercote force-pushed the symbol-related-improvements branch from 621cc66 to b24bcc8 Compare July 16, 2020 00:08
@nnethercote
Copy link
Contributor Author

@bors r=oli-obk, rollup=iffy

Iffy because it's fairly large.

@bors
Copy link
Contributor

bors commented Jul 16, 2020

📌 Commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f has been approved by oli-obk,

@bors
Copy link
Contributor

bors commented Jul 16, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2020
@nnethercote
Copy link
Contributor Author

I don't think this will have a perf effect, but let's check to be sure.

@bors try @rust-timer queue

@bors
Copy link
Contributor

bors commented Jul 16, 2020

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@nnethercote
Copy link
Contributor Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2020
@nnethercote
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 16, 2020

⌛ Trying commit b24bcc883ac9b61217c845c7d8baef8c2889ac4f with merge 4d6f6e62bd34546e4c64b9684af62346c5de2858...

@bors
Copy link
Contributor

bors commented Jul 16, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 4d6f6e62bd34546e4c64b9684af62346c5de2858 (4d6f6e62bd34546e4c64b9684af62346c5de2858)

@rust-timer
Copy link
Collaborator

Queued 4d6f6e62bd34546e4c64b9684af62346c5de2858 with parent 7e11379, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (4d6f6e62bd34546e4c64b9684af62346c5de2858): comparison url.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 16, 2020

perf looks clean with potential small improvements, just needs a rebase

@nnethercote
Remove unused cx parameter from pathvec_std and path_std.
8e92f4f
@nnethercote
Simplify LifetimeBounds.
bccff14 
The `lifetimes` field is always empty. This commit removes it, and
renames the type as `Bounds`.
@nnethercote
Remove ExtCtxt::ident_of.
9f00808 
It's equivalent to `Ident::from_str_and_span`. The commit also
introduces some more static symbols so that `Ident::new` can be used in
various places instead of `Ident::from_str_and_span`.

The commit also changes `Path::path` from a `&str` to a `Symbol`, which
then allows the lifetime annotation to be removed from `Ty`. Also, the
use of `Symbol` in `Bounds` removes the need for its lifetime
annotation.
@nnethercote
Avoid storing SymbolStr in a struct.
002af4d 
It's intended only for very temporary use.
@nnethercote
Add UnsafetyViolationDetails.
f03c7f8 
This replaces the need for the `description` and `details` symbols in
`UnsafetyViolation`, which are static. As a result some
`Symbol::as_str()` calls are no longer necessary, which is nice.
@nnethercote
Remove some Symbol:as_str() calls.
a4ba181
@nnethercote nnethercote force-pushed the symbol-related-improvements branch from b24bcc8 to a4ba181 Compare July 16, 2020 22:30
@nnethercote
Copy link
Contributor Author

I rebase.

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jul 16, 2020

📌 Commit a4ba181 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Jul 16, 2020

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74357 - nnethercote:symbol-related-improvem…
efa0441 
…ents, r=oli-obk

Some `Symbol` related improvements

These commits make things nicer and avoid some `Symbol::as_str()` calls.

r? @oli-obk
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74357 - nnethercote:symbol-related-improvem…
2497434 
…ents, r=oli-obk

Some `Symbol` related improvements

These commits make things nicer and avoid some `Symbol::as_str()` calls.

r? @oli-obk
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 16, 2020
@Manishearth
Rollup merge of rust-lang#74357 - nnethercote:symbol-related-improvem…
6a4e73e 
…ents, r=oli-obk

Some `Symbol` related improvements

These commits make things nicer and avoid some `Symbol::as_str()` calls.

r? @oli-obk
@Manishearth Manishearth mentioned this pull request Jul 16, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 17, 2020
@Manishearth
Rollup merge of rust-lang#74357 - nnethercote:symbol-related-improvem…
3029f0d 
…ents, r=oli-obk

Some `Symbol` related improvements

These commits make things nicer and avoid some `Symbol::as_str()` calls.

r? @oli-obk
This was referenced Jul 17, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2020
@bors
Auto merge of rust-lang#74422 - Manishearth:rollup-7mfrf6g, r=Manishe…
8534be7 
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73101 (Resolve items for cross-crate imports relative to the original module)
 - rust-lang#73269 (Enable some timeouts in SGX platform)
 - rust-lang#74033 (Add build support for Cargo's build-std feature.)
 - rust-lang#74351 (Do not render unstable items for rustc doc)
 - rust-lang#74357 (Some `Symbol` related improvements)
 - rust-lang#74371 (Improve ayu rustdoc theme)
 - rust-lang#74386 (Add RISC-V GNU/Linux to src/tools/build-manifest as a host platform)
 - rust-lang#74398 (Clean up E0723 explanation)

Failed merges:

r? @ghost
@bors bors merged commit c60b051 into rust-lang:master Jul 17, 2020
@nnethercote nnethercote deleted the symbol-related-improvements branch July 17, 2020 04:32
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nnethercote @oli-obk @bors @rust-timer @cuviper @rust-highfive