-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test caching opt_const_param_of on disc #74376
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 620d6883fd74efedbb67ac019186c6e76c826ea5 with merge 2e498501f591a1be258a953ea1ed225408909730... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 2e498501f591a1be258a953ea1ed225408909730 with parent 7e11379, future comparison URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, curious if perf will change.
Finished benchmarking try commit (2e498501f591a1be258a953ea1ed225408909730): comparison url. |
Looks like perf is worse 🤔 I think @bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 016205678946e3483aac1bd53417ac3c8d867296 with merge 374482ebbce140f884a62148e2a93c7ceee04adf... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 374482ebbce140f884a62148e2a93c7ceee04adf with parent e2e29de, future comparison URL. |
Heh, at least all the regressions are in non-initial incremental runs.
But when you request a HIR node, you depend on everything in it (I guess not on the body of things that have bodies, so maybe it's fine - it's similar to |
|
@lcnr the cost comes from
E.g. But apparently it's not worth it, i.e. recomputing Although, I wonder if the perf results are from caching on disk, that seems like it would matter more than the early return. |
My reasoning is that I kind of doubt that that's relevant here though, the perf impact probably just comes from caching it on disc at all 😅 |
|
Finished benchmarking try commit (374482ebbce140f884a62148e2a93c7ceee04adf): comparison url. |
🤷 let's just add a note to |
0162056
to
57fc3d3
Compare
ready for merge I guess |
57fc3d3
to
e8d16fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with title/description updated to match the current state
@bors r+ rollup |
📌 Commit e8d16fd has been approved by |
…arth Rollup of 13 pull requests Successful merges: - rust-lang#72714 (Fix debug assertion in typeck) - rust-lang#73197 (Impl Default for ranges) - rust-lang#73323 (wf: check foreign fn decls for well-formedness) - rust-lang#74051 (disallow non-static lifetimes in const generics) - rust-lang#74376 (test caching opt_const_param_of on disc) - rust-lang#74501 (Ayu theme: Use different background color for Run button) - rust-lang#74505 (Fix search input focus in ayu theme) - rust-lang#74522 (Update sanitizer docs) - rust-lang#74546 (Fix duplicate maybe_uninit_extra attribute) - rust-lang#74552 (Stabilize TAU constant.) - rust-lang#74555 (Improve "important traits" popup display on mobile) - rust-lang#74557 (Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern) - rust-lang#74561 (update backtrace-rs) Failed merges: r? @ghost
remove some const arg in ty dep path boilerplate followup to rust-lang#74113, together with rust-lang#74376, this closes rust-lang#74360. r? @eddyb
Followup to #74113, implements parts of #74360
Tried caching
opt_const_param_of
on disk and adding an early exit iftcx.dep_kind(def_id) != DefKind::AnonConst
.Ended up causing a perf regression instead, so we just remove the FIXME and a short note to
opt_const_param_of
.r? @eddyb