Move libstd's default feature to libtest #74377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it so `std` no longer has a `default` feature, but instead the `test` crate has a `default` feature doing the same thing. The purpose of this commit is to allow Cargo's `-Zbuild-std` command, which could customize the features of the standard library, to handle the `default` feature for libstd. Currently Cargo's `-Zbuild-std` support starts at libtests's manifest as the entry point to the std set of crates.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Seems fine to me -- I agree pushing things to the "workspace" (crate tree, whatever we call it) root is good. |
|
📌 Commit e158913 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 16, 2020
…imulacrum Move libstd's default feature to libtest This commit makes it so `std` no longer has a `default` feature, but instead the `test` crate has a `default` feature doing the same thing. The purpose of this commit is to allow Cargo's `-Zbuild-std` command, which could customize the features of the standard library, to handle the `default` feature for libstd. Currently Cargo's `-Zbuild-std` support starts at libtests's manifest as the entry point to the std set of crates.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 16, 2020
…arth Rollup of 7 pull requests Successful merges: - rust-lang#73421 (Clarify effect of orphan rule changes on From/Into) - rust-lang#74037 (Update reference to CONTRIBUTING.md) - rust-lang#74203 (Enforce the static symbol order.) - rust-lang#74295 (Add and fix BTreeMap comments) - rust-lang#74352 (Use local links in the alloc docs.) - rust-lang#74377 (Move libstd's default feature to libtest) - rust-lang#74381 (Update docs for str::as_bytes_mut.) Failed merges: r? @ghost
alexcrichton
added a commit
to alexcrichton/cargo
that referenced
this pull request
Jul 17, 2020
This flag is intended to pair with `-Zbuild-std` as necessary to configure the features that libstd is built with. This is highly unlikely to ever be stabilized in any form (unlike `-Zbuild-std` which we'd like to stabilize at some point), but can be useful for experimenting with the standard library. For example today it can be used to test changes to binary size by disabling backtraces. My intention is that we won't need a `--no-default-features` equivalent for libstd, where after rust-lang/rust#74377 is merged we can unconditionally specify default features are disabled but the default set of features lists `default`. That way if users want to override the list *and* include the default feature, they can just be sure to include `default`.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Jul 17, 2020
Add a `-Zbuild-std-features` flag This flag is intended to pair with `-Zbuild-std` as necessary to configure the features that libstd is built with. This is highly unlikely to ever be stabilized in any form (unlike `-Zbuild-std` which we'd like to stabilize at some point), but can be useful for experimenting with the standard library. For example today it can be used to test changes to binary size by disabling backtraces. My intention is that we won't need a `--no-default-features` equivalent for libstd, where after rust-lang/rust#74377 is merged we can unconditionally specify default features are disabled but the default set of features lists `default`. That way if users want to override the list *and* include the default feature, they can just be sure to include `default`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it so
stdno longer has adefaultfeature, butinstead the
testcrate has adefaultfeature doing the same thing.The purpose of this commit is to allow Cargo's
-Zbuild-stdcommand,which could customize the features of the standard library, to handle
the
defaultfeature for libstd. Currently Cargo's-Zbuild-stdsupport starts at libtests's manifest as the entry point to the std set
of crates.