Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some timing info to rustdoc #74590

Merged
merged 9 commits into from
Aug 24, 2020
Merged

Add some timing info to rustdoc #74590

merged 9 commits into from
Aug 24, 2020

Commits on Aug 24, 2020

  1. Add some timing info to rustdoc 

    There are various improvements, but the main one is to time each pass
that rustdoc performs (`rustdoc::passes`).

Before, these were the top five timings for `cargo doc` on the cargo
repository:

```
+---------------------------------+-----------+-----------------+----------+------------+
| Item                            | Self time | % of total time | Time     | Item count |
+---------------------------------+-----------+-----------------+----------+------------+
| <unknown>                       | 854.70ms  | 20.888          | 2.47s    | 744823     |
+---------------------------------+-----------+-----------------+----------+------------+
| expand_crate                    | 795.29ms  | 19.436          | 848.00ms | 1          |
+---------------------------------+-----------+-----------------+----------+------------+
| metadata_decode_entry           | 256.73ms  | 6.274           | 279.49ms | 518344     |
+---------------------------------+-----------+-----------------+----------+------------+
| resolve_crate                   | 240.56ms  | 5.879           | 242.86ms | 1          |
+---------------------------------+-----------+-----------------+----------+------------+
| hir_lowering                    | 146.79ms  | 3.587           | 146.79ms | 1          |
+---------------------------------+-----------+-----------------+----------+------------+
```

Now the timings are:

```
+---------------------------------+-----------+-----------------+----------+------------+
| Item                            | Self time | % of total time | Time     | Item count |
+---------------------------------+-----------+-----------------+----------+------------+
| <unknown>                       | 1.40s     | 22.662          | 3.73s    | 771430     |
+---------------------------------+-----------+-----------------+----------+------------+
| collect-trait-impls             | 1.34s     | 21.672          | 2.87s    | 1          |
+---------------------------------+-----------+-----------------+----------+------------+
| expand_crate                    | 1.21s     | 19.577          | 1.28s    | 1          |
+---------------------------------+-----------+-----------------+----------+------------+
| build extern trait impl         | 704.66ms  | 11.427          | 1.07s    | 21893      |
+---------------------------------+-----------+-----------------+----------+------------+
| metadata_decode_entry           | 354.84ms  | 5.754           | 391.81ms | 544919     |
+---------------------------------+-----------+-----------------+----------+------------+
```
    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    50a7969 View commit details
    Browse the repository at this point in the history

  2. Time loading all crates, not each individual crate

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    a0ebf1d View commit details
    Browse the repository at this point in the history

  3. Remove redundant timing for query

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    d252798 View commit details
    Browse the repository at this point in the history

  4. Separate run_global_ctxt into a separate function

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    e730947 View commit details
    Browse the repository at this point in the history

  5. Time running the global context

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    6782dc0 View commit details
    Browse the repository at this point in the history

  6. xpy fmt

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    d213784 View commit details
    Browse the repository at this point in the history

  7. Time how long it takes to render HTML

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    2934fd0 View commit details
    Browse the repository at this point in the history

  8. Use underscores instead of spaces

    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    a549c3a View commit details
    Browse the repository at this point in the history

  9. Fix bad rebase 

    Had to use -Xignore-whitespace-conflicts to avoid awful conflicts, but
that threw off the indentation
    @jyn514
    jyn514 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    6e3e74d View commit details
    Browse the repository at this point in the history