Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay_span_bug instead of silent ignore #74692

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

Mark-Simulacrum
Copy link
Member

This is a follow-up to #74557.

r? @pnkfelix

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2020
@pnkfelix
Copy link
Member

@bors r+ rollup=true

@bors
Copy link
Contributor

bors commented Jul 23, 2020

📌 Commit c4246638fafc9c76477a9f4656a370430a35b2ea has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Jul 23, 2020

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2020
@Mark-Simulacrum
Copy link
Member Author

@bors r=pnkfelix

Fixed @estebank's nit, but not going to backport that to stable (not worth the hassle).

@bors
Copy link
Contributor

bors commented Jul 23, 2020

📌 Commit 5a5846f has been approved by pnkfelix

@bors
Copy link
Contributor

bors commented Jul 23, 2020

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jul 24, 2020
delay_span_bug instead of silent ignore

This is a follow-up to rust-lang#74557.

r? @pnkfelix
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 24, 2020
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#72954 (revise RwLock for HermitCore)
 - rust-lang#74367 (Rearrange the pipeline of `pow` to gain efficiency)
 - rust-lang#74491 (Optimize away BitAnd and BitOr when possible)
 - rust-lang#74639 (Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x)
 - rust-lang#74661 (Refactor `region_name`: add `RegionNameHighlight`)
 - rust-lang#74692 (delay_span_bug instead of silent ignore)
 - rust-lang#74698 (fixed error reporting for mismatched traits)
 - rust-lang#74715 (Add a system for creating diffs across multiple mir optimizations.)

Failed merges:

r? @ghost
@bors bors merged commit db83a21 into rust-lang:master Jul 24, 2020
@cuviper
Copy link
Member

cuviper commented Jul 30, 2020

Should this also be beta-nominated to follow #74557? Especially since this was backported to stable 1.45.1, but maybe not depending the investigation of #74954.

@Mark-Simulacrum Mark-Simulacrum deleted the delay-bug branch July 30, 2020 20:01
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants