Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture tokens for Pat used in macro_rules! argument #74846

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Capture tokens for Pat used in macro_rules! argument #74846

merged 1 commit into from
Aug 21, 2020

Conversation

Aaron1011
Copy link
Member

This extends PR #73293 to handle patterns (Pat). Unlike expressions,
patterns do not support custom attributes, so we only need to capture
tokens during macro_rules! argument parsing.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2020
@Aaron1011 Aaron1011 mentioned this pull request Jul 27, 2020
Merged
@Aaron1011 Aaron1011 force-pushed the fix/pat-token-capture branch 2 times, most recently from 29ae4d1 to 233f43f Compare July 28, 2020 02:45
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 28, 2020

⌛ Trying commit 233f43f7c83fda51628b84d1aa68cb243f0eb218 with merge d990716b6a1fdde1300748828a9c9e79dfd0b898...

@petrochenkov
Copy link
Contributor

The equivalent change for expressions caused a large number of regressions, so this will probably need a check-only crater run, which is a bit annoying because the crater queue is full.
(I would expect this change to have a more modest effect though.)

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2020
@bors
Copy link
Contributor

bors commented Jul 28, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: d990716b6a1fdde1300748828a9c9e79dfd0b898 (d990716b6a1fdde1300748828a9c9e79dfd0b898)

@rust-timer
Copy link
Collaborator

Queued d990716b6a1fdde1300748828a9c9e79dfd0b898 with parent 7b3a781, future comparison URL.

@petrochenkov
Copy link
Contributor

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-74846 created and queued.
🤖 Automatically detected try build d990716b6a1fdde1300748828a9c9e79dfd0b898
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 28, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (d990716b6a1fdde1300748828a9c9e79dfd0b898): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@petrochenkov
Copy link
Contributor

@bors rollup=maybe

@crlf0710 crlf0710 added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 14, 2020
@craterbot
Copy link
Collaborator

🚧 Experiment pr-74846 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-74846 is completed!
📊 4 regressed and 6 fixed (115067 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 20, 2020
@Aaron1011
Copy link
Member Author

All of the regressions look spurious.

@petrochenkov
Copy link
Contributor

Excellent.
r=me after rebase.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@Aaron1011
Capture tokens for Pat used in macro_rules! argument
607a190 
This extends PR rust-lang#73293 to handle patterns (Pat). Unlike expressions,
patterns do not support custom attributes, so we only need to capture
tokens during macro_rules! argument parsing.
@Aaron1011 Aaron1011 force-pushed the fix/pat-token-capture branch from 233f43f to 607a190 Compare August 20, 2020 06:46
@Aaron1011
Copy link
Member Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit 607a190 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 20, 2020
@bors
Copy link
Contributor

bors commented Aug 20, 2020

⌛ Testing commit 607a190 with merge 117af305ccee87a8f1a6fcbfd0d56dbd6fb1fff4...

@bors
Copy link
Contributor

bors commented Aug 20, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 20, 2020
@petrochenkov
Copy link
Contributor

running: "sccache" "/Users/runner/work/1/s/clang+llvm-9.0.0-x86_64-darwin-apple/bin/clang" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=x86_64-apple-darwin" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=x86_64-apple-darwin" "-stdlib=libc++" "-fdebug-prefix-map=/Users/runner/work/1/s=/rustc/117af305ccee87a8f1a6fcbfd0d56dbd6fb1fff4" "-xassembler-with-cpp" "-DCFG_TARGET_OS_macos" "-DCFG_TARGET_ARCH_x86_64" "-DCFG_TARGET_ENV_" "-o" "/Users/runner/work/1/s/build/x86_64-apple-darwin/stage0-rustc/x86_64-apple-darwin/release/build/psm-02e41561f26ff64d/out/src/arch/x86_64.o" "-c" "src/arch/x86_64.s"
cargo:warning=error: Connection to server timed out

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@bors
Copy link
Contributor

bors commented Aug 21, 2020

⌛ Testing commit 607a190 with merge ff5e0f1...

@bors
Copy link
Contributor

bors commented Aug 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing ff5e0f1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2020
@bors bors merged commit ff5e0f1 into rust-lang:master Aug 21, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
##[section]Starting: Request a runner to run this job
Found online and idle self-hosted runner in current repository that matches the required labels: 'self-hosted , ARM64 , linux'

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Aaron1011 @rust-highfive @petrochenkov @rust-timer @bors @craterbot @rust-log-analyzer @cuviper @crlf0710 @matthewjasper