-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Don't print "const" keyword on non-nightly build if rustc_const_unstable is used on the item #74936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't print "const" keyword on non-nightly build if rustc_const_unstable is used on the item #74936
Conversation
r? @ollie27 (rust_highfive has picked a reviewer for you, use r? to override) |
rust/src/librustdoc/clean/mod.rs Line 883 in 2186722
constness field of header like is done elsewhere.
|
In the places I added my own check. Great! Just need to update the code I already wrote then. Thanks a lot for the pointer @ollie27 ! |
132fb86
to
9ceabe1
Compare
Updated! |
Looks good. Just needs some tests like |
…d if the "rustc_const_unstable" attribute is present
9ceabe1
to
eea11a0
Compare
Added the test. |
eea11a0
to
2a281e0
Compare
ping @rust-lang/rustdoc |
Test looks good to me, trusting Ollie's review for the code changes. @bors r+ |
📌 Commit 2a281e0 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Fixes #74579.