Do not suggest duplicate 'a lifetime
#75000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Aug 10, 2020
| (param.span.shrink_to_lo(), "'a, ".to_string()) | ||
| if param.name.ident().as_str().contains("'a") { | ||
| // Do not add duplicate lifetime. | ||
| None |
There was a problem hiding this comment.
I know there's a function somewhere to get the next one letter name. Could we use that instead? On mobile so I can't find it back can look for it tomorrow.
| help: consider making the bound lifetime-generic with a new `'a` lifetime | ||
| | | ||
| LL | struct S<'a>(&'a dyn for<'a> Fn(&'a X) -> &X<'a>); | ||
| | ^^^^^^^ ^^^^^ ^^^^^ |
There was a problem hiding this comment.
Could we also deal with this case and suggest for<'b> instead?
At a glance, it looks greater than this, I'm going to close this in favor of the above. Thanks for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72404
r? @estebank