-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refractor ty.kind -> ty.kind() and ty.flags -> ty.flags() #75077
Conversation
Oops, forgot about rustdoc... |
cc4e672
to
e72843c
Compare
Changed rustdoc and clippy |
☔ The latest upstream changes (presumably #75133) made this pull request unmergeable. Please resolve the merge conflicts. |
Thanks @LeSeulArtichaut ! For some reason, I thought we had an MCP for this change, but I guess we don't. |
I do feel like that's appropriate, I can file one |
Opened rust-lang/compiler-team#341 |
ffd573e
to
50176d0
Compare
68bb6b8
to
9986f88
Compare
☔ The latest upstream changes (presumably #74877) made this pull request unmergeable. Please resolve the merge conflicts. |
We should probably do a perf run on this too? |
@jackh726 do I need to resolve the conflicts if you want to do a perf run? |
I think we can do a try/perf run without rebasing, but I don't have perms for that. I'll make a post on Zulip. |
@bors try @rust-timer queue |
Awaiting bors try build completion |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@LeSeulArtichaut can you rebase? |
9986f88
to
e3172d6
Compare
01fd13f
to
4d28a82
Compare
All right, here we go |
📌 Commit 4d28a82 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Tested on commit rust-lang/rust@d245464. Direct link to PR: <rust-lang/rust#75077> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @eddyb @RalfJung).
Change `ty.kind` -> `ty.kind()` This fixes build failure due to rust-lang/rust#75077, cc rust-lang/rust#76337. (This is my first PR here, please tell me if anything's wrong)
First step for the "shared library to represent Rust types" work (rust-lang/types-team#16).
This PR makes the
TyS::kind
field private and adds akind()
method to access it.As noted on Zulip, this refractoring might require a MCP. I am perfectly fine with having to wait until MCP is accepted and resolving the conflicts that pop up afterwards.
r? @nikomatsakis